Skip to content

winch: Save state before emitting br_if #8886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzgen merged 1 commit into from
Jun 28, 2024
Merged

winch: Save state before emitting br_if #8886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 105 additions & 0 deletions tests/disas/winch/x64/br_if/save_state_before_br_emission.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
;;! target = "x86_64"
;;! test = "winch"
(module
(func (param f64 f64 f64 f64) (result f32 f64)
f64.const 0
local.get 0
i64.const 0
f64.const 0
i64.const 0
local.get 0
f64.const 0
i64.const 1
i32.const 1
i64.const 1
f32.const 0
local.get 0

i32.const 0
br_if 0

drop
drop
drop
drop
drop
drop
i64.reinterpret_f64
i64.const 0
i64.xor
drop
drop
drop
drop
drop
drop
f32.const 0
f64.const 0
)
)
;; wasm[0]::function[0]:
;; pushq %rbp
;; movq %rsp, %rbp
;; movq 8(%rdi), %r11
;; movq (%r11), %r11
;; addq $0x50, %r11
;; cmpq %rsp, %r11
;; ja 0x101
;; 1b: movq %rdi, %r14
;; subq $0x38, %rsp
;; movq %rdi, 0x30(%rsp)
;; movq %rsi, 0x28(%rsp)
;; movsd %xmm0, 0x20(%rsp)
;; movsd %xmm1, 0x18(%rsp)
;; movsd %xmm2, 0x10(%rsp)
;; movsd %xmm3, 8(%rsp)
;; movq %rdx, (%rsp)
;; movl $0, %eax
;; movsd 0x20(%rsp), %xmm15
;; subq $8, %rsp
;; movsd %xmm15, (%rsp)
;; movsd 0x28(%rsp), %xmm15
;; subq $8, %rsp
;; movsd %xmm15, (%rsp)
;; movsd 0x30(%rsp), %xmm15
;; subq $8, %rsp
;; movsd %xmm15, (%rsp)
;; movsd (%rsp), %xmm0
;; addq $8, %rsp
;; subq $4, %rsp
;; movss 0x72(%rip), %xmm15
;; movss %xmm15, (%rsp)
;; testl %eax, %eax
;; je 0xb6
;; a4: movl (%rsp), %r11d
;; movl %r11d, 0x10(%rsp)
;; addq $0x10, %rsp
;; jmp 0xeb
;; b6: addq $4, %rsp
;; movsd (%rsp), %xmm0
;; addq $8, %rsp
;; movq %xmm0, %rax
;; xorq $0, %rax
;; addq $8, %rsp
;; movsd 0x38(%rip), %xmm0
;; subq $4, %rsp
;; movss 0x23(%rip), %xmm15
;; movss %xmm15, (%rsp)
;; movq 4(%rsp), %rax
;; movl (%rsp), %r11d
;; addq $4, %rsp
;; movl %r11d, (%rax)
;; addq $0x38, %rsp
;; popq %rbp
;; retq
;; 101: ud2
;; 103: addb %al, (%rax)
;; 105: addb %al, (%rax)
;; 107: addb %al, (%rax)
;; 109: addb %al, (%rax)
;; 10b: addb %al, (%rax)
;; 10d: addb %al, (%rax)
;; 10f: addb %al, (%rax)
;; 111: addb %al, (%rax)
;; 113: addb %al, (%rax)
;; 115: addb %al, (%rax)
5 changes: 5 additions & 0 deletions winch/codegen/src/visitor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1711,6 +1711,11 @@ where
self.masm,
|ctx, masm| ctx.pop_to_reg(masm, None),
);
// Explicitly save any live registers and locals before setting up
// the branch state.
// In some cases, calculating the `top` value above, will result in
// a spill, thus the following one will result in a no-op.
self.context.spill(self.masm);
frame.top_abi_results::<M, _>(
&mut self.context,
self.masm,
Expand Down