Make the GC compiler interface have less boilerplate #9278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we don't even need to stub out a no-op GC compiler when GC is disabled at compile time.
This lets us differentiate between common code that is needed for any GC compiler implementation and DRC-specific code.
Just `pub use imp::*` instead
alexcrichton
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9275
I opted not to move the
translate_struct_getet al methods toGcCompilerbecause their implementation should be identical across all GC strategies (and therefore allGcCompilerimplementations). But I did the other suggested clean ups, which cut down on overall boilerplate quite a bit.