move ConcurrentState from ComponentInstance to Store
#11796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a few benefits: - No need to specify an instance when creating or piping from a stream or future. - No need to track the instance in an `Accessor`. - You may now execute tasks for multiple instances in a single event loop. The main drawback is that, if one of several instances within a single store traps, it effectively means all instances have trapped, and the store can't be used to create new instances. The way to avoid that is to use separate stores for instances which must be isolated from others. As a result of this change, a lot of code had to move from e.g. `impl Instance` to e.g. `impl StoreOpaque`, so the diff is pretty huge, but the changes themselves are almost entirely non-functional. Fixes bytecodealliance#11226 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
reviewed
Oct 6, 2025
Signed-off-by: Joel Dice <joel.dice@fermyon.com>
- restore `ComponentStoreData` encapsulation - avoid conditional code duplication in `LiftContext::new` Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Oct 6, 2025
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
…lliance#11796) * move `ConcurrentState` from `ComponentInstance` to `Store` This has a few benefits: - No need to specify an instance when creating or piping from a stream or future. - No need to track the instance in an `Accessor`. - You may now execute tasks for multiple instances in a single event loop. The main drawback is that, if one of several instances within a single store traps, it effectively means all instances have trapped, and the store can't be used to create new instances. The way to avoid that is to use separate stores for instances which must be isolated from others. As a result of this change, a lot of code had to move from e.g. `impl Instance` to e.g. `impl StoreOpaque`, so the diff is pretty huge, but the changes themselves are almost entirely non-functional. Fixes bytecodealliance#11226 Signed-off-by: Joel Dice <joel.dice@fermyon.com> * fix non-component-model-async build Signed-off-by: Joel Dice <joel.dice@fermyon.com> * fix outdated doc comment Signed-off-by: Joel Dice <joel.dice@fermyon.com> * address review feedback - restore `ComponentStoreData` encapsulation - avoid conditional code duplication in `LiftContext::new` Signed-off-by: Joel Dice <joel.dice@fermyon.com> --------- Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a few benefits:
Accessor.The main drawback is that, if one of several instances within a single store traps, it effectively means all instances have trapped, and the store can't be used to create new instances. The way to avoid that is to use separate stores for instances which must be isolated from others.
As a result of this change, a lot of code had to move from e.g.
impl Instanceto e.g.impl StoreOpaque, so the diff is pretty huge, but the changes themselves are almost entirely non-functional.Fixes #11226
Fixes #11249
Fixes #11651