Skip to content

Fix memory.init with Wizer #11876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexcrichton merged 1 commit into from
Oct 17, 2025
Merged

Fix memory.init with Wizer #11876

alexcrichton merged 1 commit into from
Oct 17, 2025

Conversation

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Oct 16, 2025

  • Preserve all data segments by default, but turn all previously active data segments into empty passive data segments.
  • Preserve all passive data segments.
  • Append all new data segments to preserve the preexisting index space.

@alexcrichton
Fix memory.init with Wizer
80fd46b 
* Preserve all data segments by default, but turn all previously active
  data segments into empty passive data segments.
* Preserve all passive data segments.
* Append all new data segments to preserve the preexisting index space.
@alexcrichton alexcrichton requested a review from a team as a code owner October 16, 2025 22:02
@alexcrichton alexcrichton requested review from fitzgen and removed request for a team October 16, 2025 22:02
@alexcrichton alexcrichton added this pull request to the merge queue Oct 17, 2025
Merged via the queue into bytecodealliance:main with commit 6b156f2 Oct 17, 2025
45 checks passed
@alexcrichton alexcrichton deleted the wizer-data-segments branch October 17, 2025 00:54
bongjunj pushed a commit to prosyslab/wasmtime that referenced this pull request Oct 20, 2025
@alexcrichton @bongjunj
Fix memory.init with Wizer (bytecodealliance#11876)
3bf771a 
* Preserve all data segments by default, but turn all previously active
  data segments into empty passive data segments.
* Preserve all passive data segments.
* Append all new data segments to preserve the preexisting index space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchickey pchickey pchickey approved these changes

@fitzgen fitzgen Awaiting requested review from fitzgen fitzgen is a code owner automatically assigned from bytecodealliance/wasmtime-core-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcrichton @pchickey