Refined Generator.java to fix a flaky error#784
Merged
Conversation
saudet
reviewed
Oct 28, 2024
saudet
approved these changes
Oct 28, 2024
Member
|
Looks good, thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a flaky error in
setUpClass()caused by inconsistent ordering of methods returned by two separategetDeclaredMethods()calls, as described in #727.The previous solution in #727 sorted methods by name, which added inefficiency. Instead, this PR merges the two
getDeclaredMethods()calls into one, ensuring a consistent method order without the need for sorting. (#727 (comment))Key Changes
Modified the function
static Method[] functionMethodsto accept the methods array as a parameter, avoiding the redundant call togetDeclaredMethods()within the function that lead to inconsistency.Related Issues
#727