Mono plugin support #196
Merged
Mono plugin support #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this only uses the L channel from the AW plugin and simply discards the R. It needs to be considered if a L+R/2 is a better solution, which it probably is.
…acAU version. AirwinRegistry now has a isMono attribute. Tried to update the Editor to only show mono compatible plugins when running in pure mono mode, but not sure I got them all...
… not support mono Currently it's overridden with "Chamber" which is the only mono reverb from the recommended list
… for instance ToTape8. As I understood Chris there is only slight variations in the flutter in that plugin so it should be okay to use in mono (I know I want to :-)
- Stereo plugins are now shown but greyed out in mono mode, to make it clear. - In settings menu there is now a layout section, with readout of bus mode. - A global option to allow stereo plugins in mono mode - And a, per plugin, setting how to handle the stereo to mono conversion: LeftOnly og LeftRightSum
…as to not change the previous behaviour (See issue baconpaul#193)
Plus a hidden setting to always show them, as I have grown quite attached to them :-)
…the mono to mono mode
Contributor
Author
|
Argh, seems like I missed a Juce 7 compile issue. Let me fix that... |
Use font.getStringWidth instead of juce::GlyphArrangement::getStringWidthInt
baconpaul
reviewed
Jul 15, 2025
Owner
baconpaul
left a comment
There was a problem hiding this comment.
This all looks great to me.
Just one name change
| - Output only Left channel (Default) | ||
| - Output L+R channel | ||
|
|
||
| The "only left channel" option will suffice for the majority of applications, but it can be experiemented with on a per plugin bases if needed. |
Owner
There was a problem hiding this comment.
This is great but I think the many item should be "Channel Layout" not "Layout" in the tool.
src-juce/AWConsolidatedEditor.cpp
Outdated
| }); | ||
| layout.addSeparator(); | ||
| layout.addItem("Bus layout: " + busLayout, false, false, []() {}); | ||
| settingsMenu.addSubMenu("Layout", layout); |
Owner
There was a problem hiding this comment.
This is the "Layout" to "Channel Layout" I think we want to swap
Owner
|
Cool I will squash merge it when ci finishes @airwindows just a heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the changes we talked about in issue #193.
Stereo plugins are now default allowed in mono->mono mode.
Mono/stereo icons are only shown in mono->mono mode.
DAW manual updated with a section about channel layout.
If any changes are need in either code or the manual (English is not my native language), I will get right on it :-)