Add AboutCard component to EntityPageOverview #2198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanalund
reviewed
Sep 1, 2020
| gridGap: theme.spacing(2), | ||
| }, | ||
| label: { | ||
| color: '#9e9e9e', |
Contributor
There was a problem hiding this comment.
Will this work in dark mode?
Contributor
Author
There was a problem hiding this comment.
I'll see if I can find a semantic color for the label 👍
Contributor
Author
There was a problem hiding this comment.
Now using theme.palette.text.secondary :)
Member
There was a problem hiding this comment.
Was that not the default? I think in the fix that @Fox32 made it looks like he removed the color specification completely.
Contributor
|
If we display the tags here in gray, I would probably switch the tags on the catalog list to gray, too. They feel a bit like screaming at one 😆 I can send a PR if you are interested. |
Contributor
|
@Fox32 yeaaaah, please do! I've been meaning to bring that up as well 😄 |
Contributor
|
Here: #2205 |
marcuseide
approved these changes
Sep 1, 2020
soapraj
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Replacing the EntityMetadataCard with new design.
fix #2039
✔️ Checklist
yarn test