Skip to content

techdocs-backend: use resolvePackagePath instead of __dirname #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rugvip merged 1 commit into from
Sep 2, 2020
Merged

techdocs-backend: use resolvePackagePath instead of __dirname #2237

Rugvip merged 1 commit into from
Sep 2, 2020

Conversation

@Rugvip
Copy link
Member

@Rugvip Rugvip commented Sep 2, 2020

__dirname doesn't refer to the same dir in production builds. We'll prolly want to add a lint rule to avoid usage of __dirname

@Rugvip Rugvip requested a review from a team as a code owner September 2, 2020 11:04
@OrkoHunter
Copy link
Member

OrkoHunter commented Sep 2, 2020

Aah nice! Thanks @Rugvip, I'll create an issue about the lint rule.

@Rugvip Rugvip merged commit 8e9326c into master Sep 2, 2020
@Rugvip Rugvip deleted the rugvip/docsdir branch September 2, 2020 13:25
@OrkoHunter OrkoHunter mentioned this pull request Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freben freben freben approved these changes

+1 more reviewer

@hooloovooo hooloovooo hooloovooo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Rugvip @OrkoHunter @hooloovooo @freben