auth-backend: refactor to split lib, move types closer to home, update docs, renaming things #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve env config to be a provider concern
soapraj
approved these changes
Sep 3, 2020
freben
approved these changes
Sep 3, 2020
| clientID: options.clientId, | ||
| clientSecret: options.clientSecret, | ||
| callbackURL: options.callbackUrl, | ||
| passReqToCallback: false as true, |
Member
Author
There was a problem hiding this comment.
TS support in passport is not great ^_>. It's tricky to wrap it up more than this though, since providers are different. May be that we should just create our own type definitions, but then that would be part of adding providers too, which is a bit meh
| logout?(): Promise<any>; | ||
| start( | ||
| req: express.Request, | ||
| options: Record<string, string>, |
Member
Author
There was a problem hiding this comment.
This is just moved, so followup PR
| !state.nonce || | ||
| !state.env || | ||
| state.nonce?.length === 0 || | ||
| state.env?.length === 0 |
Member
There was a problem hiding this comment.
Either those question marks can be left out, or just check if (!state.nonce?.length ||...
|
|
||
| const clientId = envConfig.getString('clientId'); | ||
| const clientSecret = envConfig.getString('clientSecret'); | ||
| const tenantID = envConfig.getString('tenantId'); |
| const providerId = 'gitlab'; | ||
| const clientId = envConfig.getString('clientId'); | ||
| const clientSecret = envConfig.getString('clientSecret'); | ||
| const audience = envConfig.getString('audience'); |
| }; | ||
|
|
||
| export type OAuthState = { | ||
| /* A type for the serialized value in the `state` parameter of the OAuth authorization flow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is just renaming and moving, and removing a bunch of unused types.
One larger changes is that environments are now an OAuth thing, as in we don't assume that other providers support them. That way we could simplify the setup a bit and move the responsibility for setting up the different envs to the provider factory functions.
Docs are updated so they should reflect the changes too.
Also adds a 404 for when trying to use missing auth providers.