-
Notifications
You must be signed in to change notification settings - Fork 7k
Change tsc output dir to dist-types #2278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Yep, this is an issue indeed, but tbh I don't using a separate folder is what we want to do in this case. I'm imagining it would be possible to switch the behaviour a bit for single-plugin repos, where we put the types inside Do you want to take a stab at that? Or perhaps open an issue where we can discuss different approaches. |
|
|
|
@feiming Right, we'd have to do some changes to the build process in the CLI that makes it aware of whether it's executing in single-plugin or monorepo mode, and then act accordingly. Afaik a safe way to check whether we're in a monorepo or not is to check |
|
Another option would be to do this, and change the build accordingly, but I would prefer a name like |
|
I'm fine with any name. I'm new to typescript, I have no preference. I'll switch to btw, is E2E test broken? I tried running it on master and got the same result. |
|
e2e tests require that you run |
Rugvip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! 😁
Change tsc output-dir to
buildconflicting
distdir usage, it's preventing the plugin from being built outside of backstage monorepo✔️ Checklist
yarn test