Skip to content

Conversation

@o-farooq
Copy link
Contributor

@o-farooq o-farooq commented Sep 6, 2020

Hey, I just made a Pull Request!

upgrade Storybook to version 6
this fixes #2233

✔️ Checklist

  • All tests are passing yarn test
  • Screenshots attached (for UI changes)
  • Relevant documentation updated
  • Prettier run on changed files
  • Tests added for new functionality
  • Regression tests added for bug fixes

@o-farooq o-farooq requested a review from a team as a code owner September 6, 2020 04:39
@Rugvip
Copy link
Member

Rugvip commented Sep 6, 2020

Thanks!

It looks like all of the stories have more padding around them than before. Do you know if this is an expected change when moving to v6?

@o-farooq
Copy link
Contributor Author

o-farooq commented Sep 6, 2020

Thanks!

It looks like all of the stories have more padding around them than before. Do you know if this is an expected change when moving to v6?

@Rugvip the default story renderer layout is padded in v6 which adds a 1rem padding. i have updated the preview.js to use fullscreen which would be same behavior as of 5.x .

Copy link
Member

@Rugvip Rugvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stefanalund stefanalund merged commit 83ade42 into backstage:master Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Storybook to version 6

5 participants