Refine linting of with-temp-dir
#157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From linter perspective: - `options` are now optional - `binding-name` must be a symbol - first arg must be a vector My initial hook used throws, but I moved to `reg-finding!` for its better precision and therefore better error squiggles in the editor. Adding tests for the hook helped me to verify correctness of hook. Closes babashka#155
Contributor
Author
|
@borkdude lemme know what you think. Wasn't entirely sure about how linter tests inits the clj-kondo .cache. Seems to work fine, but maybe there's a better or more proper way. |
Contributor
Author
|
Oh, I should follow test naming as per style guide: https://guide.clojure.style/#test-naming, commit coming. |
Add -test suffix to tests.
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From linter perspective:
optionsare now optionalbinding-namemust be a symbolMy initial hook used throws, but I moved to
reg-finding!for its better precision and therefore better error squiggles in the editor.Adding tests for the hook helped me to verify correctness of hook.
Closes #155
Please answer the following questions and leave the below in as part of your PR.
This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
I have updated the CHANGELOG.md file with a description of the addressed issue.