Bugfix: use == for comparison with __selfNode instead of "is" #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when adding or removing cluster nodes the added node also gets added to the list of partner nodes (by replaying the journal). Example. First I have had the cluster from only two nodes, 127.0.0.1:2222 and 127.0.0.1:2223. On the next step I added 127.0.0.1:2224 to the cluster and started it up. It resulted in the following `syncobj_admin -conn 127.0.0.1:2224 -status` output: ``` commit_idx: 153 enabled_code_version: 0 last_applied: 153 leader: 127.0.0.1:2222 leader_commit_idx: 153 log_len: 6 match_idx_count: 1 match_idx_server_127.0.0.1:2224: 0 next_node_idx_count: 1 next_node_idx_server_127.0.0.1:2224: 150 partner_node_status_server_127.0.0.1:2222: 2 partner_node_status_server_127.0.0.1:2223: 2 partner_node_status_server_127.0.0.1:2224: 0 partner_nodes_count: 3 raft_term: 1 readonly_nodes_count: 0 revision: deprecated self: 127.0.0.1:2224 self_code_version: 0 state: 0 uptime: 3 version: 0.3.7 ``` It happened because `__doChangeCluster` was using `is` operator for comparison with the __selfNode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when adding or removing cluster nodes the added node also gets added to the list of partner nodes (by replaying the journal).
Example. First I have had the cluster from only two nodes,
127.0.0.1:2222and127.0.0.1:2223.On the next step I added
127.0.0.1:2224to the cluster and started it up.It resulted in the following
syncobj_admin -conn 127.0.0.1:2224 -statusoutput:It happened because the
__doChangeCluster()method was usingisoperator for comparison with the __selfNode.