fix: Fix bug leading to double-orphaning of some pages #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
fb6b79d to
9a555e5
Compare
jjtny1
approved these changes
Jul 23, 2025
Contributor
jjtny1
left a comment
There was a problem hiding this comment.
Great find Brian! Also very clear test
2f12d14 to
5abe4f2
Compare
5abe4f2 to
a18fa9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the page orphaning logic to explicitly orphan pages as they are unreferenced, instead of doing so whenever a
PointerChange::Deleteis encountered.Adds a test which previously reproduced the double-orphan bug by simultaneously deleting an Account at the root of one page, as well as its parent Branch at the root of another page.