Remove extra @charset "UTF-8" in compiled CSS #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content style for atttachments where a "bullet" character was being injected before the element's content was causing the compiled CSS to shove an extra `@charset "UTF-8";` in the middle of the file (line ~300). This can cause warnings and possibly errors for CSS build systems. For example, this warning is emited from `postcss-loader` when importing the Trix CSS in webpack... ``` Module Warning (from ./node_modules/postcss-loader/dist/cjs.js): Warning (300:1) postcss-import: @charset must precede all other statements ``` I changed the style to use an escaped unicode version of a bullet instead of the actual character. After running `bin/blade build` locally, the extra `@charset` no longer showed up in the compiled file.
|
This pull request has been automatically marked as stale after 90 days of inactivity. It will be closed if no further activity occurs. |
|
Hi Basecamp team, this fixes an issue I'm having when compiling Trix CSS with Webpack. Could you review and merge it please? |
Eric-Guo
pushed a commit
to Eric-Guo/trix
that referenced
this pull request
Oct 30, 2021
Remove extra @charset "UTF-8" in compiled CSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content style for attachments where a "bullet" character was being
injected before the element's content was causing the compiled CSS to
shove an extra
@charset "UTF-8";in the middle of the file (line~300). This can cause warnings and possibly errors for CSS build
systems.
For example, this warning is emitted from
postcss-loaderwhen importingthe Trix CSS in webpack...
I changed the style to use an escaped unicode version of a bullet
instead of the actual character. After running
bin/blade buildlocally, the extra
@charsetno longer showed up in the compiled file.Fixes #795