Skip to content

Fix ensureAttachmentExclusivelyHasAttribute #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
afcapel merged 1 commit into from
Apr 6, 2022
Merged

Fix ensureAttachmentExclusivelyHasAttribute #967

afcapel merged 1 commit into from
Apr 6, 2022

Conversation

@afcapel
Copy link
Contributor

@afcapel afcapel commented Apr 5, 2022

The method was calling Hash.slice with a string and Hash.slice was using forEach on the string, but forEach is not defined for strings.

@afcapel
Fix ensureAttachmentExclusivelyHasAttribute
406b522 
The method was calling Hash.slice with a string and Hash.slice was using
forEach on the string, but forEach is not defined for strings.
@afcapel afcapel requested a review from kevinmcconnell April 5, 2022 16:35
kevinmcconnell
kevinmcconnell approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@kevinmcconnell kevinmcconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@afcapel afcapel merged commit 72c7404 into v2 Apr 6, 2022
@afcapel afcapel deleted the fix-attribute-check branch April 6, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmcconnell kevinmcconnell kevinmcconnell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@afcapel @kevinmcconnell