Skip to content

Conversation

@javan
Copy link
Contributor

@javan javan commented Jan 20, 2016

Because Firefox completes compositions in the last compositionupdate and then sends compositionend, Trix wouldn't perform a render because the mutation occurs while the composition is still happening, and Trix ignores mutations until they're complete.

In Chrome (and all other browsers I've tested), this is the sequence of events and mutations when composing é by pressing alt+e, then e:

compositionupdate, data = ´
elementDidMutate, composing? true
compositionend, data = é
elementDidMutate, composing? false

The same sequence in Firefox:

compositionupdate, data = ´ 
elementDidMutate, composing? true 
compositionupdate, data = é 
elementDidMutate, composing? true 
compositionend, data = é 

Before this change:
ff-composition
After:
ff-composition-after

javan added a commit that referenced this pull request Jan 21, 2016
Fix that selections remained expanded in Firefox after a composition
@javan javan merged commit 3df5272 into master Jan 21, 2016
@javan javan deleted the fix-firefox-composition-selection branch January 21, 2016 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants