Conversation
Avoids the common pitfall where users have to request a release, i.e. the inevitable slack message 'hey could you cut a release with that new fix' Relies on the repository using semver commit messages. This is already implied in this template because commitizen-tools/commitizen is installed as a commit-msg pre-commit hook. Based on https://github.com/aspect-build/rules_lint/pull/427/files where this is already observed to be working.
Member
|
Could we make it so that only minor and patch releases are cut automatically? Major releases may require a |
Contributor
Author
|
I agree on the need for that. I don't see such an affordance in the action being used, so filed smlx/ccv#161 to see what the maintainer thinks. I imagine this could be possible on our side by parsing the semver before/after info in variables, but smells like a layering violation. |
Contributor
Author
|
@fmeum that feature landed upstream and I've used the new output in the conditional. This now auto-releases only patch and minor. |
fmeum
reviewed
Dec 5, 2024
fmeum
approved these changes
Dec 5, 2024
alexeagle
added a commit
to bazel-contrib/rules_oci
that referenced
this pull request
Dec 11, 2024
Simplifies life for maintainers a bit, ensuring we're never more than two weeks without commits getting shipped. Downstreams bazel-contrib/rules-template#129
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Mar 11, 2025
Downstreams bazel-contrib/rules-template#129 Addresses #3821
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Mar 11, 2025
Downstreams bazel-contrib/rules-template#129 Addresses #3821 Also remove the bit about signing the Google CLA, which doesn't apply now that the repo was donated to Linux Foundation.
alexeagle
added a commit
to bazel-contrib/rules_nodejs
that referenced
this pull request
Mar 11, 2025
Downstreams bazel-contrib/rules-template#129 Addresses #3821 Also remove the bit about signing the Google CLA, which doesn't apply now that the repo was donated to Linux Foundation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the common pitfall where users have to request a release, i.e. the inevitable slack message 'hey could you cut a release with that new fix'
Relies on the repository using semver commit messages. This is already implied in this template because commitizen-tools/commitizen is installed as a commit-msg pre-commit hook.
Based on https://github.com/aspect-build/rules_lint/pull/427/files where this is already observed to be working.