WS-MAINTENANCE: Refactors unused cypress suites. #13557
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
reviewed
Dec 17, 2025
|
|
||
| describe('Header Tests', () => { | ||
| const serviceName = config[service]?.name || service; | ||
| const serviceName = service; |
Contributor
There was a problem hiding this comment.
Does this need aliased? Can we just use service throughout the is test?
amoore108
approved these changes
Dec 17, 2025
Contributor
amoore108
left a comment
There was a problem hiding this comment.
Thanks for this, looks great 👍
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant Cypress helper functions and configuration files to clean up the test suite. The refactoring eliminates the intermediate service configuration lookup that was mapping service identifiers to names, simplifying the codebase by using service identifiers directly.
Key changes:
- Removed the entire
settings.tsconfiguration file containing service-to-name mappings - Removed the
services.tshelper that filtered services based on environment variables - Updated test files to use service identifiers directly instead of looking up service names
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
testsForCanonicalOnly.ts |
Simplified to use service identifier directly instead of looking up service name from config |
testsForAMPOnly.ts |
Removed service config lookup, now passes service identifier directly to cy.getToggles |
settings.ts |
Deleted entire file containing service configuration mappings |
services.ts |
Deleted helper file that provided filtered service configurations |
testsForAllCanonicalPages.ts |
Removed config lookup for serviceName, uses service identifier directly |
testsForAllAMPPages.ts |
Simplified conditional by removing config lookup layer |
atiAnalytics/assertions/*.ts (11 files) |
Cleaned up import paths to use relative imports from index file instead of deeply nested absolute paths |
atiAnalytics/assertions/index.ts |
New file consolidating assertion functions previously imported from absolute paths |
crossPlatformAssertion.ts |
Removed service config lookups, uses service identifier directly throughout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: No-Jira
Summary
Removes redundant cypress helper functions.
Code changes
Developer Checklist
Testing
Ready-For-Test, Local)Ready-For-Test, Test)Ready-For-Test, Preview)Ready-For-Test, Live)Additional Testing Steps
Useful Links