Skip to content

Conversation

@dpordomingo
Copy link
Member

current:
image

Poblem to solve:

dropdown contains:

  • Java (Auto)
  • Java
  • Python

What is (imho) missleading


alternative:
image

Proposal:

Change the auto by:

  • Auto (Java)
  • Java
  • Python

Why?
In my opinion this way is clearer that the driver is not enforced by the dashboard, and the used by the server, in this case, was Java.

@dpordomingo dpordomingo self-assigned this Apr 24, 2018
@dpordomingo dpordomingo requested a review from bzz April 24, 2018 17:17
@bzz
Copy link
Contributor

bzz commented Apr 25, 2018

Was always frustrated by this label in dropdown. 👍

Wonder, why not taking it a step further, and keep just ["Autodetect", "Python", ...] and then, add another "label", a non-interactive UI element, with the current language somewhere?

Suggesting this, as right now the dropdown serves 2 purposes - allowing user to choose a mode of language detection: auto/manual AND it's also a feedback to the user about the language, detected in Auto mode. Thus confusion.

May be, as this is not super urgent, if @ricardobaeta have some spare cycles he could chime in and provide some feedback/suggestions/mocks with different options from the product side?

Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
@dpordomingo
Copy link
Member Author

I agree with you @bzz : it could be improved a lot the UX of the playground (especially the "auto" feature, that has weird behaviors when you change examples and languages)

If I understood you, you're suggesting something like this (but better designed/thought 😉 )
image

What I tried to do, is just to improve the UX of the dropdown with a small effort, so we can:

  • (a) wait till we have a new redesign of the app,
  • (b) merge if this does not break any expectation and create a new issue to avoid losing your valuable suggestions.

Whatever you choose, is ok for me :D

@dpordomingo dpordomingo requested review from erizocosmico and removed request for erizocosmico April 25, 2018 15:27
@bzz
Copy link
Contributor

bzz commented Apr 27, 2018

@dpordomingo thank you for a picture, illustrating the idea! Yes, that was exactly what I meant, sans the position of language label, which you are right, could be a subject of further improvement/investigation.

👍 for plan b for now

@dpordomingo dpordomingo merged commit f2b202f into bblfsh:master Apr 27, 2018
@dpordomingo dpordomingo deleted the auto-lang branch April 27, 2018 11:11
@dpordomingo
Copy link
Member Author

PR merged, and new issue #128 opened as agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants