Skip to content

Allow disabling both load balancer and ingress#77

Merged
benc-uk merged 1 commit into
benc-uk:masterfrom
shivjm:allow-disabling-both-load-balancer-and-ingress
Oct 30, 2021
Merged

Allow disabling both load balancer and ingress#77
benc-uk merged 1 commit into
benc-uk:masterfrom
shivjm:allow-disabling-both-load-balancer-and-ingress

Conversation

@shivjm

@shivjm shivjm commented Sep 18, 2021

Copy link
Copy Markdown
Contributor

Preserves the default behaviour of creating a load balancer, but allows disabling it with loadBalancer.enabled: false. Also changes the load balancer IP parameter from loadBalancerIP to loadBalancer.IP.

Closes #71

Preserves the default behaviour of creating a load balancer, but
allows disabling it with `loadBalancer.enabled: false`. Also changes
the load balancer IP parameter from `loadBalancerIP` to
`loadBalancer.IP`.

Closes #71

@benc-uk benc-uk left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@benc-uk benc-uk merged commit b101254 into benc-uk:master Oct 30, 2021
@shivjm shivjm deleted the allow-disabling-both-load-balancer-and-ingress branch October 30, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Helm] Don't use LoadBalancer service type by default (work behind a proxy)

2 participants