Directory download optimizations #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the zip archive creation to stream output directly from the zip process, improving memory efficiency and response time. This fixes out-of-memory crashes on low-end devices.
BrunoBernardino
requested changes
Dec 3, 2025
Member
BrunoBernardino
left a comment
There was a problem hiding this comment.
Thanks for this @medallyon ! I understand the improvements (not to lib/config.ts), but do not want to add a dependency which has a big potential for vulnerabilities just for this small benefit, I'm afraid.
If you can get these improvements from zip directly and "regular" IO streams (which I believe you can), I'd accept that.
Contributor
Author
|
That makes sense, I'll look into the proposed changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes how directory downloads work. On my relatively low-end machine that hosts bewcloud, I often encounter crashes with the new download feature due to running out of memory. This implements a streaming mechanism for directory downloads, so even multi-gigabyte directories can be downloaded without issue. It also improves the UX because browsers now instantly display the download progress (see screenshot).