This is the wrong way to handle it unfortunately.

Both login.* and interactive.* need to source environment.*

Login.* sourcing of environment.* will instruct environment.* to check if it is login and interactive, if it is, check for cache, if there is cache, save current bare env and load the cache.

Interactive.* will source and instruct environment.* to check if a cache was used, and if so, reset the current env to the saved bare env and load the setup-environment-commands and save the result as the cache.

init.sh shouldn't be changed.

in practice, the cache just needs to be the output of setup-environment-commands

In fact, setup-environment-commands itself could probably handle the loading of the cache and the saving of both caches (original and result).

Perhaps we should have login.* and interactive.* call setup-environment-commands directly, such that they can pass --login and --interactive flags or --cache flags to it appropriately. That way the environment.* commands operate as is and ignore the cache and do not write to it.

From our signal discussion, this can be and should be done entirely in user land via their environment.bash user config file.

We should update docs/dorothy/... with instructions however once we have a prototype going. Or better yet, track the caching idea in an issue with the OP having the latest instructions.

Closing this as further discussions on caching and implementation has been started in #290.

#281 is now merged which fixes this