chore(deps): bump react-datepicker from 7.3.0 to 9.0.0 #1804
Conversation
|
| resolution: {integrity: sha512-LGzKgBk5NUEcXUeSEJY2ICCCmPusm9UGRkNKRXCPgpUzoMx2CCsa0mOHTyv+itQeW7tR/jgGEpq5q/afZjGEFg==} | ||
| peerDependencies: | ||
| react: ^16.9.0 || ^17 || ^18 | ||
| react-dom: ^16.9.0 || ^17 || ^18 | ||
| date-fns-tz: ^3.0.0 | ||
| react: ^16.9.0 || ^17 || ^18 || ^19 || ^19.0.0-rc | ||
| react-dom: ^16.9.0 || ^17 || ^18 || ^19 || ^19.0.0-rc | ||
| peerDependenciesMeta: | ||
| date-fns-tz: | ||
| optional: true | ||
|
|
||
| react-dom@18.2.0: | ||
| resolution: {integrity: sha512-6IMTriUmvsjHUjNtEDudZfuDQUoWXVxKHhlEGSk81n4YFS+r/Kl99wXiwlVXtPBtJenozv2P+hxDsw9eA7Xo6g==} |
There was a problem hiding this comment.
Bug: Datepicker's custom removeOffset modifier is incompatible with react-datepicker v9.0.0's Floating UI, causing incorrect calendar positioning.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The custom removeOffset modifier in the Datepicker component uses Popper.js syntax, which is incompatible with react-datepicker v9.0.0's new Floating UI positioning library. This incompatibility will cause the modifier to be silently ignored, resulting in the calendar popup being positioned 10 pixels closer to the input field than intended, potentially leading to visual overlap and a degraded user experience.
💡 Suggested Fix
Replace the custom removeOffset modifier with Floating UI's built-in offset middleware or consult react-datepicker v9.0.0 documentation for the correct method to achieve the desired offset adjustment.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pnpm-lock.yaml#L5669-L5689
Potential issue: The custom `removeOffset` modifier in the `Datepicker` component uses
Popper.js syntax, which is incompatible with `react-datepicker` v9.0.0's new Floating UI
positioning library. This incompatibility will cause the modifier to be silently
ignored, resulting in the calendar popup being positioned 10 pixels closer to the input
field than intended, potentially leading to visual overlap and a degraded user
experience.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 6415328
621dec1 to
7af479f
Compare
Bumps [react-datepicker](https://github.com/Hacker0x01/react-datepicker) from 7.3.0 to 9.0.0. - [Release notes](https://github.com/Hacker0x01/react-datepicker/releases) - [Commits](Hacker0x01/react-datepicker@v7.3.0...v9.0.0) --- updated-dependencies: - dependency-name: react-datepicker dependency-version: 9.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7af479f to
23ad87f
Compare
Bumps react-datepicker from 7.3.0 to 9.0.0.
Release notes
Sourced from react-datepicker's releases.
... (truncated)
Commits
1afdefa9.0.0fab2eb6Merge pull request #6114 from Hacker0x01/chore/upgrade-node-versions7f5a371chore: upgrade to Node 24.x LTS and fix deprecated set-output71359dfMerge pull request #6068 from Hacker0x01/timezone-support94457edtest: add edge case test for selectsRange with only end datea59fdeetest: add coverage for legacy showTimeSelect with timezone and selectsRanged045955test: add coverage for timezone with selectsRange in handleTimeChange1ededb4Add istanbul ignore comment for untestable catch block19df127Add fallback tests for timezone functions when date-fns-tz is not installeddf6c89cAdd more timezone tests to improve coverageDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)