Skip to content

feat!: remove compatibility for Biome v1#102

Merged
siketyan merged 2 commits into
mainfrom
feat/remove-v1
Jun 17, 2025
Merged

feat!: remove compatibility for Biome v1#102
siketyan merged 2 commits into
mainfrom
feat/remove-v1

Conversation

@siketyan

@siketyan siketyan commented May 6, 2025

Copy link
Copy Markdown
Member

Warning

Breaking Change: Using the extension with Biome v1 is no longer supported. Please upgrade to Biome v2, or use older version of the extension.

Closes #97

We tried to keep compatibility for Biome v1 in #77, but it seems not working in some environments. Due to lack of debugging tools in Zed, we decided to just drop the support for Biome v1 and release a new major version.

In this pull request, appending --config-path in the LSP command line is no longer supported. If you are using a custom configuration path, it no longer work with Biome v1.

BREAKING-CHANGE: Using the extension with Biome v1 is no longer supported. Please upgrade to Biome v2, or use older version of the extension.
@siketyan siketyan requested review from a team May 6, 2025 14:57
@siketyan siketyan self-assigned this May 6, 2025
@siketyan

siketyan commented May 6, 2025

Copy link
Copy Markdown
Member Author

I'll merge and make a release once Biome v2.0 is released, to reduce confusion for Biome v1 users

@ematipico ematipico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siketyan would you mind updating:

  • the version of the extension.toml to 0.2.0
  • update the README.md. We want to highlight that v0.1.5 of the extension is only compatible with v1.9.4 of Biome, and v0.2.0 of the extension is only compatible with v2 of biome

@siketyan

Copy link
Copy Markdown
Member Author

@ematipico Updated. Feel free to reword the note in README if it's not appropriate. 🙏

@nakamorichi

nakamorichi commented Jun 4, 2025

Copy link
Copy Markdown

@siketyan Can we have pre-release? All of my projects use Biome v2, so lack of working biome support in Zed is discouraging me from using Zed althogether.

@siketyan

siketyan commented Jun 4, 2025

Copy link
Copy Markdown
Member Author

@nakamorichi I am not very familiar with Zed, and not sure if we can publish a pre-release. Do you have a documentation or something? I am happy to do that if possible :)

@nakamorichi

Copy link
Copy Markdown

@siketyan tbh, I'm also very new to Zed. I just noticed there's functionality for "Install another version" in the "Extensions" page, so I assumed it would work similarly to vscode's "Install Specific Version". In vscode I'm using pre-release of biome, because the release version doesn't work for Biome v2, and was hoping similar would be possible in Zed & Biome-Zed.

I assume the flow is same as with any extension release - of which you probably know more than me :). I don't know the supported version format syntax, but as long as there's a version containing pre-release changes, it should be possible to select that version manually. I added some screenshots that probably explain better what I mean.

It could also be that support for pre-release versions needs to be properly implemented into Zed itself; not sure.

https://zed.dev/docs/extensions/developing-extensions?highlight=extens#publishing-your-extension

Screenshot 2025-06-04 at 12 09 33 Screenshot 2025-06-04 at 12 09 40 Screenshot 2025-06-04 at 12 11 19

@XiNiHa

XiNiHa commented Jun 17, 2025

Copy link
Copy Markdown

Are we having this merged now that we have v2 stable released?

@siketyan

Copy link
Copy Markdown
Member Author

@XiNiHa Thanks for the reminder!

@siketyan siketyan merged commit 7ed58ff into main Jun 17, 2025
3 checks passed
@chungweileong94

Copy link
Copy Markdown
Contributor

FYI, I also just submitted a PR to the Zed Extensions repo, so anyone can get the latest release once it's merged.
zed-industries/extensions#2863

@siketyan

Copy link
Copy Markdown
Member Author

Oh, I even didn't know that we require a manual PR 😅 Thank you!

@chungweileong94

Copy link
Copy Markdown
Contributor

So if I understand correctly, I just realized that v0.2.0 is technically still working with Biome v1 (mostly, but no guarantee in the future), as long as we don't use the --config-path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Doesn't seem to work with 2.0.0 yet

5 participants