crates/biome_analyze/CONTRIBUTING.md (1)

1010-1032: ⚠️ Potential issue | 🟠 Major

Fix the multi-signal example's return type.

The code declares type Signals = Option<Box<[Self::State]>> but returns a bare boxed slice without the outer Option wrapper. Additionally, the .map(|write| Some(range)) creates unwanted nested Options. The return should be Some(write_ranges.into_boxed_slice()) and the map should yield bare range values instead.

Suggested correction

         let write_ranges = write_references.into_iter().map(|write| {
             let syntax = write.syntax();
             let range = syntax.text_range();

-            Some(range)
+            range
         }).collect::<Vec<_>>();

-        write_ranges.into_boxed_slice()
+        Some(write_ranges.into_boxed_slice())

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_analyze/CONTRIBUTING.md` around lines 1010 - 1032, The example's
declared Signals type (type Signals = Option<Box<[Self::State]>>) doesn't match
the returned value: in run(...) you collect write_ranges as a boxed slice but
forget to wrap it in Some, and the map currently produces nested Options via
.map(|write| Some(range)); change the map to yield the bare range from
binding.all_writes(...) (e.g., .map(|write| write.syntax().text_range()) ) and
return Some(write_ranges.into_boxed_slice()) so run returns an
Option<Box<[Self::State]>> as declared.