fix(organizeImports): error on unknown predefined groups by Conaclos · Pull Request #10205 · biomejs/biome

Conaclos · 2026-05-02T15:56:28Z

Summary

Fix #10185

Fix #10168

organizeImports's option deserialization now errors on unknown predefined groups.

This PR also improves the docs of organizeImports documenting what the source field accepts.

Test Plan

I added a test.

Docs

I added a changeset.

changeset-bot · 2026-05-02T15:56:33Z

🦋 Changeset detected

Latest commit: 15c6352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-02T16:01:13Z

Walkthrough

The PR makes assist.actions.source.organizeImports validation stricter: unknown predefined import group names now produce a deserialization diagnostic (with a special-case message for :BLANK_LINE:). Documentation for the source field was clarified to state it accepts predefined groups and glob patterns. A test JSON example demonstrating an invalid configuration using an unknown predefined group was added, and the deserializer now reports errors instead of silently ignoring unrecognised predefined groups.

Possibly related PRs

feat(organizeImports): add :STYLE: group matcher #10070 — Adds a new predefined matcher :STYLE: in the same import_groups.rs area where predefined group parsing/validation is implemented.
feat(organizeImports): add kind field to import matcher #10074 — Modifies import-group matching/deserialization logic in import_groups.rs, affecting how matchers and sources are parsed and validated.
docs(orgnizeImports): revamp user-facing docs #9987 — Documentation changes touching the same organize_imports.rs docs paragraph that was updated here.

Suggested labels

L-JSON

Suggested reviewers

dyc3
ematipico

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarises the primary change: fixing organizeImports to error on unknown predefined groups.
Description check	✅ Passed	The description is directly related to the changeset, explaining the fix for issues `#10185` and `#10168`, deserialization changes, and documentation improvements.
Linked Issues check	✅ Passed	The code changes fully address the requirements: deserialization now validates predefined groups [`#10185`], errors on unknown names and :BLANK_LINE: in matchers [`#10185`], and documentation improved [`#10168`].
Out of Scope Changes check	✅ Passed	All changes directly support the linked objectives: changeset metadata, test case, documentation updates, and deserializer error handling for unknown groups.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch conaclos/error-on-inexistent-predef-groups

_{Review rate limit: 4/5 reviews remaining, refill in 12 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

crates/biome_js_analyze/src/assist/source/organize_imports.rs (1)

204-205: ⚡ Quick win

Clarify that :BLANK_LINE: is excluded from source matchers.

Line 204 is close, but a tiny explicit exception avoids confusion.

Suggested patch

-/// The `source` field accepts predefined groups and glob patterns.
+/// The `source` field accepts predefined source groups (except `:BLANK_LINE:`) and glob patterns.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/biome_js_analyze/src/assist/source/organize_imports.rs` around lines
204 - 205, Update the doc comment that describes the `source` field in
organize_imports.rs to explicitly state that the special matcher `:BLANK_LINE:`
is excluded from `source` matchers; locate the doc block that begins "The
`source` field accepts predefined groups and glob patterns." and add one brief
sentence clarifying that `:BLANK_LINE:` will not be matched by `source`
expressions so readers don’t expect blank-line matching there.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/hungry-parts-enter.md:
- Line 5: Replace the existing Line 5 entry with the mandated changeset bugfix
format by changing it to: Fixed
[`#10185`](https://github.com/biomejs/biome/issues/10185): `organizeImports` now
errors when it encounters a non-existent predefined group — i.e., add the
missing colon after the issue link, wrap the action name organizeImports in
backticks, and change “inexistent predefine group” to “non-existent predefined
group.”

In `@crates/biome_rule_options/src/organize_imports/import_groups.rs`:
- Around line 267-271: Fix the typo in the diagnostic note string used in the
.with_note(markup! { ... }) call: replace "eleemtn of of the " with "element of
the " so the message reads that ":BLANK_LINE:" can only be placed as an element
of the "groups" array; update the text inside the markup! invocation in
import_groups.rs accordingly.

---

Nitpick comments:
In `@crates/biome_js_analyze/src/assist/source/organize_imports.rs`:
- Around line 204-205: Update the doc comment that describes the `source` field
in organize_imports.rs to explicitly state that the special matcher
`:BLANK_LINE:` is excluded from `source` matchers; locate the doc block that
begins "The `source` field accepts predefined groups and glob patterns." and add
one brief sentence clarifying that `:BLANK_LINE:` will not be matched by
`source` expressions so readers don’t expect blank-line matching there.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d08bfd33-e839-4b8b-ac98-7937957b942f

📥 Commits

Reviewing files that changed from the base of the PR and between 1a2d354 and 7ba3e46.

⛔ Files ignored due to path filters (1)

crates/biome_js_analyze/tests/specs/source/organizeImports/invalid-config-inexistent-predef-group.js.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (5)

.changeset/hungry-parts-enter.md
crates/biome_js_analyze/src/assist/source/organize_imports.rs
crates/biome_js_analyze/tests/specs/source/organizeImports/invalid-config-inexistent-predef-group.js
crates/biome_js_analyze/tests/specs/source/organizeImports/invalid-config-inexistent-predef-group.options.json
crates/biome_rule_options/src/organize_imports/import_groups.rs

codspeed-hq · 2026-05-02T16:12:01Z

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 196 skipped benchmarks¹

_{Comparing conaclos/error-on-inexistent-predef-groups (15c6352) with main (dc0c877)²}

196 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (1a2d354) during the generation of this report, so dc0c877 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

ematipico

Messages have typos, and don't provide solutions. They must be improved

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@crates/biome_rule_options/src/organize_imports/import_groups.rs`:
- Around line 261-273: The code currently only treats ":BLANK_LINE:" as a
positional misuse but reports "!:BLANK_LINE:" as an unknown group; update the
branch that builds the DeserializationDiagnostic so it first strips a leading
'!' (e.g. let base = text.strip_prefix("!").unwrap_or(&text);) and then compare
base == ":BLANK_LINE:" to produce the "isn't valid in this position. Remove it."
message (DeserializationDiagnostic::new with Emphasis for the token), otherwise
keep the existing "doesn't exist" message that uses format_args!("{}", base) as
before; adjust references to text where needed so the Emphasis shows the
original token including the '!' when present.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3803d191-f454-41cb-b8be-e9a89ce6962d

📥 Commits

Reviewing files that changed from the base of the PR and between 574e66b and 15c6352.

⛔ Files ignored due to path filters (1)

crates/biome_js_analyze/tests/specs/source/organizeImports/invalid-config-inexistent-predef-group.js.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (2)

.changeset/hungry-parts-enter.md
crates/biome_rule_options/src/organize_imports/import_groups.rs

✅ Files skipped from review due to trivial changes (1)

.changeset/hungry-parts-enter.md

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.4.14` -> `2.4.15`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.4.14/2.4.15) | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.4.15`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2415) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.4.14...@biomejs/biome@2.4.15) ##### Patch Changes - [#9394](biomejs/biome#9394) [`ba3480e`](biomejs/biome@ba3480e) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`useTestHooksInOrder`](https://biomejs.dev/linter/rules/use-test-hooks-in-order) in the `test` domain. The rule enforces that Jest/Vitest lifecycle hooks (`beforeAll`, `beforeEach`, `afterEach`, `afterAll`) are declared in the order they execute, making test setup and teardown easier to reason about. - [#10254](biomejs/biome#10254) [`e0a54cc`](biomejs/biome@e0a54cc) Thanks [@dyc3](https://github.com/dyc3)! - Added a new nursery rule [`useVueNextTickPromise`](https://biomejs.dev/linter/rules/use-vue-next-tick-promise/), which enforces Promise syntax when using Vue `nextTick`. For example, the following snippet triggers the rule: ```js import { nextTick } from "vue"; nextTick(() => { updateDom(); }); ``` - [#10219](biomejs/biome#10219) [`64aee45`](biomejs/biome@64aee45) Thanks [@dyc3](https://github.com/dyc3)! - Added a new nursery rule [`noVueVOnNumberValues`](https://biomejs.dev/linter/rules/no-vue-v-on-number-values/), that disallows deprecated number modifiers on Vue `v-on` directives. For example, the following snippet triggers the rule: ```vue <input @keyup.13="submit" /> ``` - [#10195](biomejs/biome#10195) [`7b8d4e1`](biomejs/biome@7b8d4e1) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`useVueValidVFor`](https://biomejs.dev/linter/rules/use-vue-valid-v-for/), which validates Vue `v-for` directives and reports invalid aliases, missing component keys, and keys that do not use iteration variables. - [#10238](biomejs/biome#10238) [`1110256`](biomejs/biome@1110256) Thanks [@dyc3](https://github.com/dyc3)! - Added the recommended nursery rule [`noVueImportCompilerMacros`](https://biomejs.dev/linter/rules/no-vue-import-compiler-macros/), which disallows importing Vue compiler macros such as `defineProps` from `vue` because they are automatically available. - [#10201](biomejs/biome#10201) [`1a08f89`](biomejs/biome@1a08f89) Thanks [@realknove](https://github.com/realknove)! - Fixed [#10193](biomejs/biome#10193): `style/useReadonlyClassProperties` no longer reports class properties as readonly-able when they are assigned inside arrow callbacks nested in class property initializers. - [#9574](biomejs/biome#9574) [`3bd2b6a`](biomejs/biome@3bd2b6a) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed [#9530](biomejs/biome#9530). The diagnostics of [`organizeImports`](https://biomejs.dev/assist/actions/organize-imports/) are now more detailed and more precise. They are also better at localizing where the issue is. - [#10205](biomejs/biome#10205) [`a704a6c`](biomejs/biome@a704a6c) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed [#10185](biomejs/biome#10185). [\`organizeImports](https://biomejs.dev/assist/actions/organize-imports/) now errors when it encounters an unknown predefined group. The following configuration is now reported as invalid because `:INEXISTENT:` is an unknown predefined group. ```json { "assist": { "actions": { "source": { "organizeImports": { "options": { "groups": [":INEXISTENT:"] } } } } } } ``` - [#10052](biomejs/biome#10052) [`b565bed`](biomejs/biome@b565bed) Thanks [@minseong0324](https://github.com/minseong0324)! - Improved [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/): it now flags union annotations whose extra variants are never returned, and suggests the narrower type (e.g. `string | null` → `string`). These functions are now reported because `null` and `number` are included in the return annotations but never returned: ```ts function getUser(): string | null { return "hello"; } // null is never returned function getCode(): string | number { return "hello"; } // number is never returned ``` - [#10213](biomejs/biome#10213) [`ac30057`](biomejs/biome@ac30057) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#9450](biomejs/biome#9450): HTML and Vue element formatting now preserves child line breaks when an element contains another element child on its own line, instead of collapsing the child element onto the same line. - [#10275](biomejs/biome#10275) [`9ee6c03`](biomejs/biome@9ee6c03) Thanks [@solithcy](https://github.com/solithcy)! - Fixed [#10274](biomejs/biome#10274): Svelte templates with missing expressions no longer parsed as `HtmlBogusElement` - [#10143](biomejs/biome#10143) [`56798a7`](biomejs/biome@56798a7) Thanks [@minseong0324](https://github.com/minseong0324)! - [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) now detects misleading return type annotations when object literal properties are initialized with `as const`. This function is now reported because the return annotation widens a property initialized with `as const`: ```ts function f(): { value: string } { return { value: "text" as const }; } ``` - [#10143](biomejs/biome#10143) [`56798a7`](biomejs/biome@56798a7) Thanks [@minseong0324](https://github.com/minseong0324)! - [`noUselessTypeConversion`](https://biomejs.dev/linter/rules/no-useless-type-conversion/) now detects redundant conversions on object literal properties initialized with `as const`. This conversion is now reported because `message.value` is inferred as a string literal: ```ts const message = { value: "text" as const }; String(message.value); ``` - [#9807](biomejs/biome#9807) [`0ae5840`](biomejs/biome@0ae5840) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`useThisInClassMethods`](https://biomejs.dev/linter/rules/use-this-in-class-methods/), based on ESLint's `class-methods-use-this`. The rule now reports instance methods, getters, setters, and function-valued instance fields that do not use `this`, and `biome migrate eslint` preserves the supported `ignoreMethods`, `ignoreOverrideMethods`, and `ignoreClassesWithImplements` options. **Invalid**: ```js class Foo { bar() { // does not use `this`, invalid console.log("Hello Biome"); } } ``` - [#10258](biomejs/biome#10258) [`e7b18f7`](biomejs/biome@e7b18f7) Thanks [@ematipico](https://github.com/ematipico)! - Improved linter performance by narrowing the query nodes for several lint rules, reducing how often they are evaluated. - [#10273](biomejs/biome#10273) [`04e22a1`](biomejs/biome@04e22a1) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10271](biomejs/biome#10271): The HTML parser now correctly parses `of` as text content when in text contexts. - [#9838](biomejs/biome#9838) [`83f7385`](biomejs/biome@83f7385) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`noBaseToString`](https://biomejs.dev/linter/rules/no-base-to-string/), which reports stringification sites that fall back to Object's default `"[object Object]"` formatting. The rule also supports the `ignoredTypeNames` option. - [#10143](biomejs/biome#10143) [`56798a7`](biomejs/biome@56798a7) Thanks [@minseong0324](https://github.com/minseong0324)! - [`useExhaustiveSwitchCases`](https://biomejs.dev/linter/rules/use-exhaustive-switch-cases/) now checks switch statements over object literal properties initialized with `as const`. This switch is now reported because `status.kind` is inferred as the string literal `"ready"` but no case handles it: ```ts const status = { kind: "ready" as const }; switch (status.kind) { } ``` - [#10143](biomejs/biome#10143) [`56798a7`](biomejs/biome@56798a7) Thanks [@minseong0324](https://github.com/minseong0324)! - [`useStringStartsEndsWith`](https://biomejs.dev/linter/rules/use-string-starts-ends-with/) now detects string index comparisons on object literal properties initialized with `as const`. This comparison is now reported because `message.value` is inferred as a string literal: ```ts const message = { value: "hello" as const }; message.value[0] === "h"; ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/12

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.4.14` -> `2.4.15`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.4.14/2.4.15) | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.4.15`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2415) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.4.14...@biomejs/biome@2.4.15) ##### Patch Changes - [#9394](biomejs/biome#9394) [`ba3480e`](biomejs/biome@ba3480e) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`useTestHooksInOrder`](https://biomejs.dev/linter/rules/use-test-hooks-in-order) in the `test` domain. The rule enforces that Jest/Vitest lifecycle hooks (`beforeAll`, `beforeEach`, `afterEach`, `afterAll`) are declared in the order they execute, making test setup and teardown easier to reason about. - [#10254](biomejs/biome#10254) [`e0a54cc`](biomejs/biome@e0a54cc) Thanks [@dyc3](https://github.com/dyc3)! - Added a new nursery rule [`useVueNextTickPromise`](https://biomejs.dev/linter/rules/use-vue-next-tick-promise/), which enforces Promise syntax when using Vue `nextTick`. For example, the following snippet triggers the rule: ```js import { nextTick } from "vue"; nextTick(() => { updateDom(); }); ``` - [#10219](biomejs/biome#10219) [`64aee45`](biomejs/biome@64aee45) Thanks [@dyc3](https://github.com/dyc3)! - Added a new nursery rule [`noVueVOnNumberValues`](https://biomejs.dev/linter/rules/no-vue-v-on-number-values/), that disallows deprecated number modifiers on Vue `v-on` directives. For example, the following snippet triggers the rule: ```vue <input @keyup.13="submit" /> ``` - [#10195](biomejs/biome#10195) [`7b8d4e1`](biomejs/biome@7b8d4e1) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`useVueValidVFor`](https://biomejs.dev/linter/rules/use-vue-valid-v-for/), which validates Vue `v-for` directives and reports invalid aliases, missing component keys, and keys that do not use iteration variables. - [#10238](biomejs/biome#10238) [`1110256`](biomejs/biome@1110256) Thanks [@dyc3](https://github.com/dyc3)! - Added the recommended nursery rule [`noVueImportCompilerMacros`](https://biomejs.dev/linter/rules/no-vue-import-compiler-macros/), which disallows importing Vue compiler macros such as `defineProps` from `vue` because they are automatically available. - [#10201](biomejs/biome#10201) [`1a08f89`](biomejs/biome@1a08f89) Thanks [@realknove](https://github.com/realknove)! - Fixed [#10193](biomejs/biome#10193): `style/useReadonlyClassProperties` no longer reports class properties as readonly-able when they are assigned inside arrow callbacks nested in class property initializers. - [#9574](biomejs/biome#9574) [`3bd2b6a`](biomejs/biome@3bd2b6a) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed [#9530](biomejs/biome#9530). The diagnostics of [`organizeImports`](https://biomejs.dev/assist/actions/organize-imports/) are now more detailed and more precise. They are also better at localizing where the issue is. - [#10205](biomejs/biome#10205) [`a704a6c`](biomejs/biome@a704a6c) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed [#10185](biomejs/biome#10185). [\`organizeImports](https://biomejs.dev/assist/actions/organize-imports/) now errors when it encounters an unknown predefined group. The following configuration is now reported as invalid because `:INEXISTENT:` is an unknown predefined group. ```json { "assist": { "actions": { "source": { "organizeImports": { "options": { "groups": [":INEXISTENT:"] } } } } } } ``` - [#10052](biomejs/biome#10052) [`b565bed`](biomejs/biome@b565bed) Thanks [@minseong0324](https://github.com/minseong0324)! - Improved [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/): it now flags union annotations whose extra variants are never returned, and suggests the narrower type (e.g. `string | null` → `string`). These functions are now reported because `null` and `number` are included in the return annotations but never returned: ```ts function getUser(): string | null { return "hello"; } // null is never returned function getCode(): string | number { return "hello"; } // number is never returned ``` - [#10213](biomejs/biome#10213) [`ac30057`](biomejs/biome@ac30057) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#9450](biomejs/biome#9450): HTML and Vue element formatting now preserves child line breaks when an element contains another element child on its own line, instead of collapsing the child element onto the same line. - [#10275](biomejs/biome#10275) [`9ee6c03`](biomejs/biome@9ee6c03) Thanks [@solithcy](https://github.com/solithcy)! - Fixed [#10274](biomejs/biome#10274): Svelte templates with missing expressions no longer parsed as `HtmlBogusElement` - [#10143](biomejs/biome#10143) [`56798a7`](biomejs/biome@56798a7) Thanks [@minseong0324](https://github.com/minseong0324)! - [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) now detects misleading return type annotations when object literal properties are initialized with `as const`. This function is now reported because the return annotation widens a property initialized with `as const`: ```ts function f(): { value: string } { return { value: "text" as const }; } ``` - [#10143](biomejs/biome#10143) [`56798a7`](biomejs/biome@56798a7) Thanks [@minseong0324](https://github.com/minseong0324)! - [`noUselessTypeConversion`](https://biomejs.dev/linter/rules/no-useless-type-conversion/) now detects redundant conversions on object literal properties initialized with `as const`. This conversion is now reported because `message.value` is inferred as a string literal: ```ts const message = { value: "text" as const }; String(message.value); ``` - [#9807](biomejs/biome#9807) [`0ae5840`](biomejs/biome@0ae5840) Thanks [@dyc3](https://github.com/dyc3)! - Added the new nursery rule [`useThisInClassMethods`](https://biomejs.dev/linter/rules/use-this-in-class-methods/), based on ESLint's `class-methods-use-this`. The rule now reports instance methods, getters, setters, and function-valued instance fields that do not use `this`, and `biome migrate eslint` preserves the supported `ignoreMethods`, `ignoreOverrideMethods`, and `ignoreClassesWithImplements` options. **Invalid**: ```js class Foo { bar() { // does not use `this`, invalid console.log("Hello Biome"); } } ``` - [#10258](biomejs/biome#10258) [`e7b18f7`](biomejs/biome@e7b18f7) Thanks [@ematipico](https://github.com/ematipico)! - Improved linter performance by narrowing the query nodes for several lint rules, reducing how often they are evaluated. - [#10273](biomejs/biome#10273) [`04e22a1`](biomejs/biome@04e22a1) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10271](biomejs/biome#10271): The HTML parser now correctly parses `of` as text content when in text contexts. - [#9838](biomejs/biome#9838) [`83f7385`](biomejs/biome@83f7385) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`noBaseToString`](https://biomejs.dev/linter/rules/no-base-to-string/), which reports stringification sites that fall back to Object's default `"[object Object]"` formatting. The rule also supports the `ignoredTypeNames` option. - [#10143](biomejs/biome#10143) [`56798a7`](biomejs/biome@56798a7) Thanks [@minseong0324](https://github.com/minseong0324)! - [`useExhaustiveSwitchCases`](https://biomejs.dev/linter/rules/use-exhaustive-switch-cases/) now checks switch statements over object literal properties initialized with `as const`. This switch is now reported because `status.kind` is inferred as the string literal `"ready"` but no case handles it: ```ts const status = { kind: "ready" as const }; switch (status.kind) { } ``` - [#10143](biomejs/biome#10143) [`56798a7`](biomejs/biome@56798a7) Thanks [@minseong0324](https://github.com/minseong0324)! - [`useStringStartsEndsWith`](https://biomejs.dev/linter/rules/use-string-starts-ends-with/) now detects string index comparisons on object literal properties initialized with `as const`. This comparison is now reported because `message.value` is inferred as a string literal: ```ts const message = { value: "hello" as const }; message.value[0] === "h"; ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/3

github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels May 2, 2026

Conaclos changed the title ~~fix(organizeImports): Error on unknown predefined groups~~ fix(organizeImports): error on unknown predefined groups May 2, 2026

Conaclos requested review from a team May 2, 2026 15:59

fix(organizeImports): Error on inexistent predefined groups

7ba3e46

coderabbitai Bot reviewed May 2, 2026

View reviewed changes

Comment thread .changeset/hungry-parts-enter.md Outdated

Comment thread crates/biome_rule_options/src/organize_imports/import_groups.rs Outdated

Fix diagnostic message

574e66b

ematipico requested changes May 2, 2026

View reviewed changes

Conaclos requested a review from ematipico May 2, 2026 21:19

coderabbitai Bot reviewed May 2, 2026

View reviewed changes

Comment thread crates/biome_rule_options/src/organize_imports/import_groups.rs

Fix typos and improve diagnostics

15c6352

ematipico approved these changes May 2, 2026

View reviewed changes

Conaclos merged commit a704a6c into main May 2, 2026
30 checks passed

Conaclos deleted the conaclos/error-on-inexistent-predef-groups branch May 2, 2026 22:42

github-actions Bot mentioned this pull request May 2, 2026

ci: release #10210

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(organizeImports): error on unknown predefined groups#10205

fix(organizeImports): error on unknown predefined groups#10205
Conaclos merged 3 commits into
mainfrom
conaclos/error-on-inexistent-predef-groups

Conaclos commented May 2, 2026

Uh oh!

changeset-bot Bot commented May 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 2, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

codspeed-hq Bot commented May 2, 2026 •

edited

Loading

Uh oh!

ematipico left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Conaclos commented May 2, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codspeed-hq Bot commented May 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

ematipico left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot Bot commented May 2, 2026 •

edited

Loading

coderabbitai Bot commented May 2, 2026 •

edited

Loading

codspeed-hq Bot commented May 2, 2026 •

edited

Loading