fix(lint/js): correct the rule source of `noReactNativeDeepImports` by siketyan · Pull Request #10344 · biomejs/biome

siketyan · 2026-05-11T16:15:53Z

Summary

Added a new rule source EslintReactNativeIntellicode to distinguish it from the official (facebook/react) one. Existing rules that are from the intellicode one are updated to use the new rule source.

Test Plan

N/A

Docs

N/A

changeset-bot · 2026-05-11T16:15:59Z

🦋 Changeset detected

Latest commit: 6de8a89

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-11T16:19:02Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e2eb8b23-0900-4093-a7fa-fe9a2c426392

📥 Commits

Reviewing files that changed from the base of the PR and between c158d16 and d48cb0e.

📒 Files selected for processing (1)

.changeset/seven-cats-stay.md

✅ Files skipped from review due to trivial changes (1)

.changeset/seven-cats-stay.md

Walkthrough

This PR adds a new RuleSource variant EslintReactNativeIntellicode, updates Display/as_rule_name/namespace/to_rule_url handling to distinguish Intellicode vs the official React Native plugin, and switches three React Native lint rules to use the Intellicode variant. A changeset documents a patch release and fixes the noReactNativeDeepImports source mapping (issue #10123).

Possibly related PRs

biomejs/biome#9871: Modifies the same RuleSource enum and trait implementations to add new ESLint plugin source variants.
biomejs/biome#10023: Introduced the noReactNativeDeepImports rule referenced by issue #10123 that this changeset documents.
biomejs/biome#10033: Added UseReactNativePlatformComponents, which this PR updates to reference the Intellicode variant.

Suggested reviewers

ematipico
dyc3

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly addresses the main issue: correcting the rule source mapping for `noReactNativeDeepImports` to reference the proper upstream Intellicode plugin.
Description check	✅ Passed	The description explains the core change—adding `EslintReactNativeIntellicode` and updating affected rules—and directly references the resolved issue `#10123`.
Linked Issues check	✅ Passed	The PR successfully adds the `EslintReactNativeIntellicode` enum variant and updates four React Native rules to use the correct source, resolving issue `#10123`'s requirement for proper rule source attribution.
Out of Scope Changes check	✅ Passed	All changes are scoped to the stated objective: introducing the new rule source variant and updating existing Intellicode-sourced rules. No extraneous modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/GH-10123

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.changeset/seven-cats-stay.md:
- Line 5: Update the changeset entry text to link the referenced rule name to
the Biome docs by replacing the plain rule name `noReactNativeDeepImports` with
the required website link format; use the markdown link format
[`noReactNativeDeepImports`](https://biomejs.dev/linter/rules/noReactNativeDeepImports/)
so the changeset line reads something like "Corrected the
[`noReactNativeDeepImports`](https://biomejs.dev/linter/rules/noReactNativeDeepImports/)
source rule..." to satisfy the documentation-linking guideline.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a14eeb08-02f1-4079-a85a-c4ca9b21abbb

📥 Commits

Reviewing files that changed from the base of the PR and between d50546a and c158d16.

📒 Files selected for processing (5)

.changeset/seven-cats-stay.md
crates/biome_analyze/src/rule.rs
crates/biome_js_analyze/src/lint/nursery/no_react_native_literal_colors.rs
crates/biome_js_analyze/src/lint/nursery/no_react_native_raw_text.rs
crates/biome_js_analyze/src/lint/nursery/use_react_native_platform_components.rs

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

codspeed-hq · 2026-05-11T16:30:34Z

Merging this PR will not alter performance

✅ 178 untouched benchmarks
⏩ 71 skipped benchmarks¹

_{Comparing fix/GH-10123 (6de8a89) with main (b6d9e57)}

71 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.4.15` -> `2.4.16`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.4.15/2.4.16) | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.4.16`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2416) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.4.15...@biomejs/biome@2.4.16) ##### Patch Changes - [#10329](biomejs/biome#10329) [`ef764d5`](biomejs/biome@ef764d5) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed an issue where diagnostics showed an incorrect location in Astro files. - [#10363](biomejs/biome#10363) [`50aa415`](biomejs/biome@50aa415) Thanks [@dyc3](https://github.com/dyc3)! - Fixed HTML formatting for a case where comments could cause the formatter to split up a closing tag, which would cause the resulting HTML to be syntactically invalid. Input: ```html ab ``` Output: ```diff  a</span >bab ``` - [#10465](biomejs/biome#10465) [`0c718da`](biomejs/biome@0c718da) Thanks [@dfedoryshchev](https://github.com/dfedoryshchev)! - Fixed diagnostics emitted by the `noUntrustedLicenses` rule. - [#10358](biomejs/biome#10358) [`05c2617`](biomejs/biome@05c2617) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10356](biomejs/biome#10356): `biome rage --linter` now displays rules enabled through linter domains in the enabled rules list. - [#10300](biomejs/biome#10300) [`950247c`](biomejs/biome@950247c) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10265](biomejs/biome#10265): Svelte function bindings such as `bind:value={get, set}` are now parsed more precisely, so [`noCommaOperator`](https://biomejs.dev/linter/rules/no-comma-operator/) won't emit false positives for that syntax anymore. - [#9786](biomejs/biome#9786) [`e71f584`](biomejs/biome@e71f584) Thanks [@MeGaNeKoS](https://github.com/MeGaNeKoS)! - Fixed [#8480](biomejs/biome#8480): [`useDestructuring`](https://biomejs.dev/linter/rules/use-destructuring/) now provides `variableDeclarator` and `assignmentExpression` options to control which contexts enforce destructuring, matching ESLint's `prefer-destructuring` configuration. Both default to `{array: true, object: true}`. The diagnostic for object destructuring in assignment expressions now instructs users to wrap the assignment in parentheses. - [#10425](biomejs/biome#10425) [`1948b72`](biomejs/biome@1948b72) Thanks [@sjh9714](https://github.com/sjh9714)! - Fixed [#10244](biomejs/biome#10244): The `useOptionalChain` rule now detects negated guard inequality chains like `!foo || foo.bar !== "x"`. - [#10442](biomejs/biome#10442) [`001f94f`](biomejs/biome@001f94f) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10411](biomejs/biome#10411): [`noMisusedPromises`](https://biomejs.dev/linter/rules/no-misused-promises/) no longer causes a stack overflow when a nested function returns an object with shorthand properties that shadow destructured variables from an outer scope. - [#10318](biomejs/biome#10318) [`9b1577f`](biomejs/biome@9b1577f) Thanks [@dyc3](https://github.com/dyc3)! - Added support for `formatter.trailingCommas` in overrides. This option was previously available in the top-level formatter configuration but missing from formatter overrides. - [#10319](biomejs/biome#10319) [`2e37709`](biomejs/biome@2e37709) Thanks [@dyc3](https://github.com/dyc3)! - Fixed Vue and Svelte formatting for standalone interpolations in inline elements. Biome now preserves existing newlines in cases like: ```diff - {{ value }} + + {{ value }} + ``` - [#10365](biomejs/biome#10365) [`0a58eb0`](biomejs/biome@0a58eb0) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10361](biomejs/biome#10361): [`noUnusedFunctionParameters`](https://biomejs.dev/linter/rules/no-unused-function-parameters/) now mentions the parameter name in the diagnostic. - [#10439](biomejs/biome#10439) [`df6b867`](biomejs/biome@df6b867) Thanks [@denbezrukov](https://github.com/denbezrukov)! - Fixed CSS and SCSS formatting for comments around declaration colons so comments between property names, colons, and values stay at the same boundary as Prettier. ```diff .selector { - color: /* red, */ - blue; + color: /* red, */ blue; } ``` - [#10344](biomejs/biome#10344) [`b30208c`](biomejs/biome@b30208c) Thanks [@siketyan](https://github.com/siketyan)! - Fixed [`#10123`](biomejs/biome#10123): Corrected the [`noReactNativeDeepImports`](https://biomejs.dev/linter/rules/no-react-native-deep-imports/) source rule to point to the proper upstream rule, so users can migrate from the original rule correctly. - [#10328](biomejs/biome#10328) [`b59133f`](biomejs/biome@b59133f) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10309](biomejs/biome#10309): Biome no longer adds newlines to Astro frontmatter when linter or assist `--write` mode is enabled. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/5

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.4.15` -> `2.4.16`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.4.15/2.4.16) | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.4.16`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2416) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.4.15...@biomejs/biome@2.4.16) ##### Patch Changes - [#10329](biomejs/biome#10329) [`ef764d5`](biomejs/biome@ef764d5) Thanks [@Conaclos](https://github.com/Conaclos)! - Fixed an issue where diagnostics showed an incorrect location in Astro files. - [#10363](biomejs/biome#10363) [`50aa415`](biomejs/biome@50aa415) Thanks [@dyc3](https://github.com/dyc3)! - Fixed HTML formatting for a case where comments could cause the formatter to split up a closing tag, which would cause the resulting HTML to be syntactically invalid. Input: ```html ab ``` Output: ```diff  a</span >bab ``` - [#10465](biomejs/biome#10465) [`0c718da`](biomejs/biome@0c718da) Thanks [@dfedoryshchev](https://github.com/dfedoryshchev)! - Fixed diagnostics emitted by the `noUntrustedLicenses` rule. - [#10358](biomejs/biome#10358) [`05c2617`](biomejs/biome@05c2617) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10356](biomejs/biome#10356): `biome rage --linter` now displays rules enabled through linter domains in the enabled rules list. - [#10300](biomejs/biome#10300) [`950247c`](biomejs/biome@950247c) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10265](biomejs/biome#10265): Svelte function bindings such as `bind:value={get, set}` are now parsed more precisely, so [`noCommaOperator`](https://biomejs.dev/linter/rules/no-comma-operator/) won't emit false positives for that syntax anymore. - [#9786](biomejs/biome#9786) [`e71f584`](biomejs/biome@e71f584) Thanks [@MeGaNeKoS](https://github.com/MeGaNeKoS)! - Fixed [#8480](biomejs/biome#8480): [`useDestructuring`](https://biomejs.dev/linter/rules/use-destructuring/) now provides `variableDeclarator` and `assignmentExpression` options to control which contexts enforce destructuring, matching ESLint's `prefer-destructuring` configuration. Both default to `{array: true, object: true}`. The diagnostic for object destructuring in assignment expressions now instructs users to wrap the assignment in parentheses. - [#10425](biomejs/biome#10425) [`1948b72`](biomejs/biome@1948b72) Thanks [@sjh9714](https://github.com/sjh9714)! - Fixed [#10244](biomejs/biome#10244): The `useOptionalChain` rule now detects negated guard inequality chains like `!foo || foo.bar !== "x"`. - [#10442](biomejs/biome#10442) [`001f94f`](biomejs/biome@001f94f) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10411](biomejs/biome#10411): [`noMisusedPromises`](https://biomejs.dev/linter/rules/no-misused-promises/) no longer causes a stack overflow when a nested function returns an object with shorthand properties that shadow destructured variables from an outer scope. - [#10318](biomejs/biome#10318) [`9b1577f`](biomejs/biome@9b1577f) Thanks [@dyc3](https://github.com/dyc3)! - Added support for `formatter.trailingCommas` in overrides. This option was previously available in the top-level formatter configuration but missing from formatter overrides. - [#10319](biomejs/biome#10319) [`2e37709`](biomejs/biome@2e37709) Thanks [@dyc3](https://github.com/dyc3)! - Fixed Vue and Svelte formatting for standalone interpolations in inline elements. Biome now preserves existing newlines in cases like: ```diff - {{ value }} + + {{ value }} + ``` - [#10365](biomejs/biome#10365) [`0a58eb0`](biomejs/biome@0a58eb0) Thanks [@Netail](https://github.com/Netail)! - Fixed [#10361](biomejs/biome#10361): [`noUnusedFunctionParameters`](https://biomejs.dev/linter/rules/no-unused-function-parameters/) now mentions the parameter name in the diagnostic. - [#10439](biomejs/biome#10439) [`df6b867`](biomejs/biome@df6b867) Thanks [@denbezrukov](https://github.com/denbezrukov)! - Fixed CSS and SCSS formatting for comments around declaration colons so comments between property names, colons, and values stay at the same boundary as Prettier. ```diff .selector { - color: /* red, */ - blue; + color: /* red, */ blue; } ``` - [#10344](biomejs/biome#10344) [`b30208c`](biomejs/biome@b30208c) Thanks [@siketyan](https://github.com/siketyan)! - Fixed [`#10123`](biomejs/biome#10123): Corrected the [`noReactNativeDeepImports`](https://biomejs.dev/linter/rules/no-react-native-deep-imports/) source rule to point to the proper upstream rule, so users can migrate from the original rule correctly. - [#10328](biomejs/biome#10328) [`b59133f`](biomejs/biome@b59133f) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10309](biomejs/biome#10309): Biome no longer adds newlines to Astro frontmatter when linter or assist `--write` mode is enabled. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/13

fix(lint/js): correct the rule source of noReactNativeDeepImports

c158d16

siketyan requested review from a team May 11, 2026 16:15

siketyan self-assigned this May 11, 2026

github-actions Bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels May 11, 2026

coderabbitai Bot reviewed May 11, 2026

View reviewed changes

Comment thread .changeset/seven-cats-stay.md Outdated

siketyan and others added 2 commits May 12, 2026 01:19

Update .changeset/seven-cats-stay.md

d48cb0e

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

[autofix.ci] apply automated fixes

6de8a89

github-actions Bot added the A-CLI Area: CLI label May 11, 2026

dyc3 approved these changes May 11, 2026

View reviewed changes

ematipico approved these changes May 11, 2026

View reviewed changes

siketyan merged commit b30208c into main May 12, 2026
37 checks passed

siketyan deleted the fix/GH-10123 branch May 12, 2026 00:15

github-actions Bot mentioned this pull request May 12, 2026

ci: release #10326

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(lint/js): correct the rule source of `noReactNativeDeepImports`#10344

fix(lint/js): correct the rule source of `noReactNativeDeepImports`#10344
siketyan merged 3 commits into
mainfrom
fix/GH-10123

siketyan commented May 11, 2026

Uh oh!

changeset-bot Bot commented May 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codspeed-hq Bot commented May 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

siketyan commented May 11, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot Bot commented May 11, 2026 •

edited

Loading

coderabbitai Bot commented May 11, 2026 •

edited

Loading

codspeed-hq Bot commented May 11, 2026 •

edited

Loading