crates/biome_js_analyze/src/lint/style/no_process_env.rs (1)

103-114: ⚡ Quick win

Avoid allocating and rescanning ancestors in is_env_from_process.

This path runs per candidate member access; collecting ancestors into a Vec adds avoidable overhead.

♻️ Proposed refactor

 fn is_env_from_process(binding: &biome_js_semantic::Binding) -> bool {
     const PROCESS_MODULE_NAMES: [&str; 2] = ["process", "node:process"];
-    let ancestors: Vec<_> = binding.syntax().ancestors().collect();
-    ancestors
-        .iter()
-        .find_map(|n| AnyJsNamedImportSpecifier::cast(n.clone())?.imported_name())
-        .is_some_and(|name| name.text_trimmed() == "env")
-        && ancestors
-            .iter()
-            .find_map(|n| JsImport::cast(n.clone())?.source_text().ok())
-            .is_some_and(|src| PROCESS_MODULE_NAMES.contains(&src.text()))
+    let imports_env = binding
+        .syntax()
+        .ancestors()
+        .find_map(|n| AnyJsNamedImportSpecifier::cast(n)?.imported_name())
+        .is_some_and(|name| name.text_trimmed() == "env");
+
+    let from_process_module = binding
+        .syntax()
+        .ancestors()
+        .find_map(|n| JsImport::cast(n)?.source_text().ok())
+        .is_some_and(|src| PROCESS_MODULE_NAMES.contains(&src.text()));
+
+    imports_env && from_process_module
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/biome_js_analyze/src/lint/style/no_process_env.rs` around lines 103 -
114, The function is_env_from_process currently collects
binding.syntax().ancestors() into a Vec and rescans it twice; change it to a
single non-allocating pass over binding.syntax().ancestors() (iterate the
iterator directly) and track two booleans (found_env and found_process_src) as
you inspect each ancestor: if AnyJsNamedImportSpecifier::cast yields an
imported_name equal to "env" set found_env, and if JsImport::cast yields a
source_text matching "process" or "node:process" set found_process_src; return
found_env && found_process_src as the result. This removes the Vec allocation
and dual scans while keeping the logic in is_env_from_process.

crates/biome_js_analyze/tests/specs/style/noProcessEnv/invalidImportedEnv.js (1)

1-3: ⚡ Quick win

Add a direct node:process named-import invalid fixture as well.

Nice start. You currently cover direct import for process and aliased import for node:process; adding a non-aliased import { env } from 'node:process' fixture would lock the full behaviour matrix.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/biome_js_analyze/tests/specs/style/noProcessEnv/invalidImportedEnv.js`
around lines 1 - 3, Add a parallel invalid fixture that uses a named import from
the node:process specifier; specifically create/update a test that does "import
{ env } from 'node:process'" and then references env.NODE_ENV and env.HOME so
the runner covers the non-aliased node:process named-import case (symbols: env
and the import statement "import { env } from 'node:process'"). Ensure this new
fixture mirrors the existing invalidImportedEnv.js usage pattern so the full
behaviour matrix is tested.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

crates/biome_js_analyze/src/lint/style/no_process_env.rs (1)

103-114: 💤 Low value

Optional: avoid intermediate Vec allocation.

The ancestors can be iterated twice directly rather than collecting into a Vec first. Minor optimisation, feel free to defer.

♻️ Suggested change

 fn is_env_from_process(binding: &biome_js_semantic::Binding) -> bool {
     const PROCESS_MODULE_NAMES: [&str; 2] = ["process", "node:process"];
-    let ancestors: Vec<_> = binding.syntax().ancestors().collect();
-    ancestors
+    binding
+        .syntax()
+        .ancestors()
-        .iter()
-        .find_map(|n| AnyJsNamedImportSpecifier::cast(n.clone())?.imported_name())
+        .find_map(|n| AnyJsNamedImportSpecifier::cast(n)?.imported_name())
         .is_some_and(|name| name.text_trimmed() == "env")
-        && ancestors
+        && binding
+            .syntax()
+            .ancestors()
-            .iter()
-            .find_map(|n| JsImport::cast(n.clone())?.source_text().ok())
+            .find_map(|n| JsImport::cast(n)?.source_text().ok())
             .is_some_and(|src| PROCESS_MODULE_NAMES.contains(&src.text()))
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/biome_js_analyze/src/lint/style/no_process_env.rs` around lines 103 -
114, The code in is_env_from_process allocates a Vec by collecting
binding.syntax().ancestors() but only needs to iterate ancestors twice; remove
the intermediate Vec and call binding.syntax().ancestors() directly for each
check instead (i.e. replace ancestors.iter().find_map(...) and the second
ancestors.iter().find_map(...) with two separate calls to
binding.syntax().ancestors().find_map(...)). Keep the same casts to
AnyJsNamedImportSpecifier and JsImport and the same checks (imported_name() ==
"env" and source_text() in PROCESS_MODULE_NAMES) but invoke
binding.syntax().ancestors() twice to avoid the temporary allocation.