crates/biome_rule_options/src/organize_imports/import_groups.rs (1)

31-33: ⚡ Quick win

Tighten these helper visibilities.

These look like internal plumbing for the validator/matcher path, so pub feels a bit generous. Exposing them widens the public API for free, which is rarely a bargain. pub(crate) for ImportGroups::has_bare_matchers and private methods for the other two should be enough here.

♻️ Proposed tweak

 impl ImportGroups {
@@
-    pub fn has_bare_matchers(&self) -> bool {
+    pub(crate) fn has_bare_matchers(&self) -> bool {
         self.0.iter().any(|group| group.has_bare_matchers())
     }
@@
 impl GroupMatcher {
@@
-    pub fn has_bare_matchers(&self) -> bool {
+    fn has_bare_matchers(&self) -> bool {
         match self {
             Self::Import(import_matcher) => import_matcher
                 .kind
                 .is_some_and(|kind_matcher| kind_matcher.kind.is_bare()),
             Self::Source(_source_matcher) => false,
         }
     }
@@
 impl ImportKindMatcher {
@@
-    pub const fn is_bare(&self) -> bool {
+    const fn is_bare(&self) -> bool {
         matches!(self, Self::Bare)
     }
 }

Also applies to: 149-156, 328-329

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/biome_rule_options/src/organize_imports/import_groups.rs` around lines
31 - 33, The helper visibility is too broad: change the public signature of
ImportGroups::has_bare_matchers from pub fn to pub(crate) fn and make the other
two helper methods mentioned in the review (the internal matcher/validator
helpers referenced at lines 149-156 and 328-329) private (remove pub) so they
are not exposed in the public API; update their declarations (method names
matching those ranges) accordingly and run tests to ensure no external call
sites rely on them.