fix(formatter): dedent logic inconsistent with prettier where the indent-style is space and the indent-width is not 2.#2134
Merged
ah-yu merged 19 commits intoApr 10, 2024
Conversation
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #2134 will not alter performanceComparing Summary
|
ematipico
requested changes
Mar 19, 2024
Contributor
Author
|
Thank you for the review!! |
1 task
Contributor
Contributor
Author
|
Big thanks @Sec-ant. With your help, I was able to add test to the |
ah-yu
reviewed
Mar 25, 2024
….com/mdm317/biome into fix/dedent-when-indentstyle-is-space
ah-yu
reviewed
Mar 27, 2024
ah-yu
approved these changes
Apr 8, 2024
ah-yu
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Left some nitpicks
Sec-ant
reviewed
Apr 8, 2024
ah-yu
reviewed
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I created a stack named 'indent_stack' to store the records of indentations in order to remove the nearest indention when StartDedent and restore indention when EndDedent
Fixes #2037
Test Plan
I couldn't add test code because errors occurred only in settings where the indent-style is space and the indent-width is not 2.
We can check through the playground.