fix: update ga4gh.vrs version + add back VRS type anno in models #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsstevenson
previously approved these changes
Aug 20, 2024
Contributor
jsstevenson
left a comment
There was a problem hiding this comment.
I think this fix also lets us revert the model_dump calls in the API responses?
if location:
return {"location": location.model_dump(exclude_none=True)}
Contributor
Author
|
I removed my anyvar container, so I didn't test the last commit. Will come back to this later to test and request review afterwards. |
ehclark
approved these changes
Aug 20, 2024
Contributor
ehclark
left a comment
There was a problem hiding this comment.
Added an additional change to the response schema to get the unit tests to pass. The responses for the register endpoints should return a model object if the call to model_dump() is removed.
Contributor
Author
|
@ehclark thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #91