Skip to content

Conversation

@A6GibKm
Copy link
Collaborator

@A6GibKm A6GibKm commented Sep 7, 2024

No description provided.

@A6GibKm A6GibKm changed the title Cli add collection arg cli: Add collection arg Sep 7, 2024
@bilelmoussaoui
Copy link
Owner

Can you rebase this one please?

@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 10, 2024

Can you rebase this one please?

Rebased, but I think we should use Login. Note too that this string is translatable in other projects.

@A6GibKm A6GibKm force-pushed the cli-add-collection-arg branch from e69adb7 to 198b1fb Compare September 10, 2024 18:36
@bilelmoussaoui
Copy link
Owner

Can you rebase this one please?

Rebased, but I think we should use Login. Note too that this string is translatable in other projects.

Hmm, that makes providing both the helper methods & constants weird. As the CLI tool could become translatable, not the oo7 library itself...

@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 10, 2024

Can you rebase this one please?

Rebased, but I think we should use Login. Note too that this string is translatable in other projects.

Hmm, that makes providing both the helper methods & constants weird. As the CLI tool could become translatable, not the oo7 library itself...

Sounds like a problem for tomorrow, but it makes sense to have it translatable everywhere.

@bilelmoussaoui
Copy link
Owner

Can you rebase this one please?

Rebased, but I think we should use Login. Note too that this string is translatable in other projects.

Hmm, that makes providing both the helper methods & constants weird. As the CLI tool could become translatable, not the oo7 library itself...

Sounds like a problem for tomorrow, but it makes sense to have it translatable everywhere.

I went ahead and add various helper APIs here that makes the whole thing nicer while allowing people to translate things if they want to.

@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 18, 2024

rebased, but please don't merge just yet, the arg is not properly working , e.g.

$ cargo run -- search --collection c a=b
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.40s
     Running `/var/home/msandova/Projects/oo7/target/debug/oo7-cli search --collection c a=b`
error: unexpected argument '--collection' found

  tip: to pass '--collection' as a value, use '-- --collection'

Usage: oo7-cli search [OPTIONS] [ATTRIBUTES]...

For more information, try '--help'.

@A6GibKm A6GibKm force-pushed the cli-add-collection-arg branch from 198b1fb to 6690da0 Compare September 18, 2024 08:55
Copy link
Owner

@bilelmoussaoui bilelmoussaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm, once you solved the cli arg parser issue :)

@A6GibKm A6GibKm force-pushed the cli-add-collection-arg branch from 6690da0 to 86c0672 Compare September 18, 2024 20:13
@A6GibKm
Copy link
Collaborator Author

A6GibKm commented Sep 18, 2024

otherwise lgtm, once you solved the cli arg parser issue :)

Done, it was a matter of using global=true.

@bilelmoussaoui bilelmoussaoui merged commit 6d2ef6c into main Sep 19, 2024
7 checks passed
@bilelmoussaoui bilelmoussaoui deleted the cli-add-collection-arg branch September 19, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants