Skip to content

client: Stop giving mac as Zeroizing #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

client: Stop giving mac as Zeroizing #279

merged 1 commit into from
Jul 25, 2025

Conversation

@A6GibKm
Copy link
Collaborator

@A6GibKm A6GibKm commented Jul 25, 2025

A mac does not contain sensitive data (no more than a hash at least), it does not need zeroizing on drop.

@A6GibKm
client: Stop giving mac as Zeroizing
0a591c4 
A mac does not contain sensitive data (no more than a hash at least), it
does not need zeroizing on drop.
@A6GibKm A6GibKm requested a review from ueno July 25, 2025 08:29
ueno
ueno approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I suspect that we could hide the content of MAC behind a newtype to make sure the values are always compared in a constant-time manner (i.e. using memcmp::eq), or at least suggesting that, though it might require changes in the other parts of the API.

@bilelmoussaoui bilelmoussaoui merged commit a212ebe into bilelmoussaoui:main Jul 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ueno ueno ueno approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A6GibKm @ueno @bilelmoussaoui