Fix DaoSnapshotService threading issues #7354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alvasw
commented
Jan 9, 2025
- DaoSnapshot: Fix persistingBlockInProgress data race
- The persistingBlockInProgress field is read by the block parsing thread. However, the block parsing thread and user thread write to the persistingBlockInProgress field. The block parsing thread might see the update too late and trigger another snapshot before the previous was done.
- DaoSnapshot: Skip snapshot creation early if another in progress
- Check if another snapshot creation is in progress before doing any computation.
- DaoSnapshot: Fix isParseBlockChainComplete field data race
- DaoSnapshot: Fix race condition in applySnapshot
- DaoSnapshot: Fix resyncDaoStateFromResources race condition
The persistingBlockInProgress field is read by the block parsing thread. However, the block parsing thread and user thread write to the persistingBlockInProgress field. The block parsing thread might see the update too late and trigger another snapshot before the previous was done.
Check if another snapshot creation is in progress before doing any computation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.