For Cycle 67

## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`8733.62`** 
- USD requested: 20000 
- BSQ rate: 2.29 USD per BSQ 
- Previous compensation request (if applicable): #1700 


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | ---: | --- | --- |
| PR Review (for v1.9.19): Optimise/simplify some stream filtering for the REST API | dev | | https://github.com/bisq-network/bisq/pull/7221 | utACK - While reviewing this PR I found and fixed unrelated threading issues. |
| PR Review (for v1.9.19): Remove emzy bsq explorer | dev | | https://github.com/bisq-network/bisq/pull/7213 | NACK - This PR adds the changes to the wrong place. This mistake wasn't caught in PR 7014. The Preferences class already has a clearRetiredNodes method that handles this use-case. I created follow-up PRs to resolve this issue. |
| PR Review (for v1.9.19): Rename provider repository | dev | | https://github.com/bisq-network/bisq/pull/7214 | utACK |
| PR Review (for v1.9.19): Add bisq.mempool.emzy.de to filter of persisted preferences | dev | | https://github.com/bisq-network/bisq/pull/7222 | utACK |
| PR Review (for v1.9.19): Add 2 new BTC nodes | dev | | https://github.com/bisq-network/bisq/pull/7231 | utACK |
| PR Review (for v1.9.19): Produce exclusively low-R signatures from wallet keys | dev | | https://github.com/bisq-network/bisq/pull/7238 | utACK. |
| PR Review (for v1.9.19): Add missing isBmFullNode parameter | dev | | https://github.com/bisq-network/bisq/pull/7239 | utACK |
| PR Review (for v1.9.19): Fix broken low-R signing with a password encrypted wallet | dev | | https://github.com/bisq-network/bisq/pull/7242 | utACK |
| PR Review (for v1.9.19): URL was broken with the /bisq path and just redirecting to mempool front page | dev | | https://github.com/bisq-network/bisq/pull/7246 | ACK |
| PR Review (for v1.9.19): Add suddenwhipvapor onion xmr explorer | dev | | https://github.com/bisq-network/bisq/pull/7245 | utACK |
| PR Review (for v1.9.19): Update seednode burningman oracle keys | dev | | https://github.com/bisq-network/bisq/pull/7248 | utACK |
| PR Review (for v1.9.19): Sort foreign alphabet payment methods above the untranslated ones. | dev | | https://github.com/bisq-network/bisq/pull/7251 | utACK - The regex matches ASCII characters according to the Windows-1252 (CP-1252) spec which is a superset of ISO 8859-1 (ISO-Latin-1) but that is fine in our case. |
| PR Review (for v1.9.19): Improve exception msg and handling when 'Same Bank' BIC/SWIFT blank | dev | | https://github.com/bisq-network/bisq/pull/7258 | utACK |
| PR Review (for v1.9.19): "Transfer Same Bank" & "Transfer Specific Banks" match case-insentitivity | dev | | https://github.com/bisq-network/bisq/pull/7257 | utACK |
| PR Review (for v1.9.19): Language strings file cleanup; added missing, applied rename | dev | | https://github.com/bisq-network/bisq/pull/7253 | utACK |
| PR Review (for v1.9.19): Create payment method "Faster Payments System (SBP)" for Russian Ruble | dev | | https://github.com/bisq-network/bisq/pull/7255 | ACK + Nit - <ul><li>SbpForm has a redundant cast to SbpAccountPayload</li><li>SbpForm has a redundant BankNameField variable declaration.</li><li>SbpForm defines holder name getters and setters that are identical to superclass.</li><li>It's hard for the seller to read the buyer's account details because the string is long, e.g, "Account owner name (first, middle, and initial of last name): Alice A., Mobile no. +71234567890, Bank name SBP Bank". I shortened "Account owner name (first, middle, and initial of last
name)" to "Account owner name".</li></ul> I created follow-up PRs that resolve these issues. |
| PR Review (for v1.9.19): Fix randomly blank currency box upon opening the Offer screen | dev | | https://github.com/bisq-network/bisq/pull/7259 | utACK |
| PR Review (for v1.9.19): New option in PhoneNumberValidator to enforce exact number of digits | dev | | https://github.com/bisq-network/bisq/pull/7252 | Nit - Jamaica (JMM) has two codes. I created a follow-up PR to fix this. |
| PR Review (for v1.9.19): Create payment method "Faster Payments System (SBP)" for Russian Ruble | dev | | https://github.com/bisq-network/bisq/pull/7265 | utACK - I used a translator to verify the Persian, Chinese Simplified, and Chinese Traditional translations. It would be good for native speakers to verify the translations. |
| PR Review (for v1.9.19): Added 500+ string translations to Russian language file | dev | | https://github.com/bisq-network/bisq/pull/7268 | utACK |
| PR Review (for v1.9.19): Added 500+ string translations to Russian language file | dev | | https://github.com/bisq-network/bisq/pull/7269 | utACK |
| PR Review (for v1.9.19): Add missing swagger doc directory | dev | | https://github.com/bisq-network/bisq/pull/7299 | utACK |
| PR Review (for v1.9.19): Update seednode install script to generate ECDSA key for BM oracle node | dev | | https://github.com/bisq-network/bisq/pull/7325 | utACK |
| PR Review (for v1.9.19): Add instruction to select JDK version at build time | dev | | https://github.com/bisq-network/bisq/pull/7327 | utACK |
| PR Review (for v1.9.19): Fix typo in Argentinian Peso (ARS) message | dev | | https://github.com/bisq-network/bisq/pull/7326 | utACK |
| PR Review (for v1.9.19): fix: remove unnecessary null check, use correct marker class, add mis… | dev | | https://github.com/bisq-network/bisq/pull/7348 | utACK |
| PR Review (for v1.9.19): Add link to trading rules wiki article in Tac Window | dev | | https://github.com/bisq-network/bisq/pull/7349 | utACK |
| PR Review (for v1.9.19): Add suddenwhipvapor mediator instance onion | dev | | https://github.com/bisq-network/bisq/pull/7350 | utACK |
| PR Review (for v1.9.19): fix: Utilities.getShortId and FluentProtocol.preCondition usage | dev | | https://github.com/bisq-network/bisq/pull/7351 | utACK |
| PR Review (for v1.9.19): Prepare activation to reduce min security deposit | dev | | https://github.com/bisq-network/bisq/pull/7357 | utACK |
| PR Review (for v1.9.19): Change MIN_SECURITY_DEPOSIT_CHANGE_ACTIVATION_DATE to 17.2.2025 | dev | | https://github.com/bisq-network/bisq/pull/7364 | utACK |
| PR Review (for v1.9.19): Reduce maximum trade size for unsigned payment accounts | dev | | https://github.com/bisq-network/bisq/pull/7364 | utACK - I found some bugs while I was reviewing this PR. |
| PR Review (for v1.9.19): Ensure AutoConfirmSettings is reset if it contains my retired explorer | dev | | https://github.com/bisq-network/bisq/pull/7364 | utACK - I found some bugs while I was reviewing this PR. |
| Fixed, re-wrote, and tested (on all OSes) Bisq 1 installer verification instructions | dev | | | https://bisq.wiki/Downloading_and_installing#Bisq_1:_Obtain_signature_files_for_installer_files |
| bisq: PR Review bisq-network/bisq#7364 | dev | | https://github.com/bisq-network/bisq/pull/7364 | utACK |
| bisq: PR Review bisq-network/bisq#7365 | dev | | https://github.com/bisq-network/bisq/pull/7365 | utACK |
| bisq: PR Review bisq-network/bisq#7368 | dev | | https://github.com/bisq-network/bisq/pull/7368 | utACK |
| bisq: PR Review bisq-network/bisq#7373 | dev | | https://github.com/bisq-network/bisq/pull/7373 | DAO hashes match with my full nodes. |
| bisq: PR Review bisq-network/bisq#7374 | dev | | https://github.com/bisq-network/bisq/pull/7374 | utACK |
| bisq: PR Review bisq-network/bisq#7375 | dev | | https://github.com/bisq-network/bisq/pull/7375 | utACK |
| bisq: PR Review bisq-network/bisq#7386 | dev | | https://github.com/bisq-network/bisq/pull/7386 | utACK |
| bisq: Makefile: Add exec-commands to .PHONY target | dev | | https://github.com/bisq-network/bisq/pull/7369 | Add bitcoind, seednode, seednode2, mediator, alice, bob, block, and blocks to .PHONY target. |
| bisq: Sbp trade UI fixes | dev | | https://github.com/bisq-network/bisq/pull/7370 | <ul dir="auto"> <li><a href="https://github.com/bisq-network/bisq/commit/0890f0eac0e5352771e3fd3d8d24d688c040317e">SbpForm: Remove redundant cast to SbpAccountPayload</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/64e001834426d0dc121c3e8ce0d1723e043837c5">SbpForm: Remove unused bank name variable declaration</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/ef2a62e2f01c4918614a834a83a1f96285f2e751">SbpForm: Remove holder name getter and setter (already in super class)</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/656b3c55965fd8df1263c76af84808084d7dbac0">AccountAgeWitnessService: Invert toleration condition</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/c42a8ef823592cbbfefb3b04bff2a3e673eb038b">displayString: Rename payment.account.owner to payment.account.owner.fullname</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/da733998bc2b2ab35165a6201162bf77207765d3">SBP Trade: Make account name description readable</a> <ul dir="auto"> <li>It's hard for the seller to read the buyer's account details because the string is long, e.g, "Account owner name (first, middle, and initial of last name): Alice A., Mobile no. +71234567890, Bank name SBP Bank". I shortened "Account owner name (first, middle, and initial of last name)" to "Account owner name".</li> </ul> </li> </ul> |
| bisq: Update Alejandro's public key | dev | | https://github.com/bisq-network/bisq/pull/7371 | Alejandro's GPG key expired and he extended the key's expiration date. |
| bisq: Fix phone number required lengths | dev | | https://github.com/bisq-network/bisq/pull/7372 | <ul dir="auto"> <li><a href="https://github.com/bisq-network/bisq/commit/321e86f128b7dccccbfc305b881cea064dc1c155">PhoneNumberRequiredLengths: Jamaica (JMM) has two codes</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/729dcb7a1695af4c654fd9021e9eb4769dc00efc">PhoneNumberRequiredLengths: Puerto Rico (PR) has two codes</a></li> </ul> |
| bisq: XMR: Fix broken subaddress docs link | dev | | https://github.com/bisq-network/bisq/pull/7377 | |
| bisq: Improve XMR subaddress popup behaviour | dev | | https://github.com/bisq-network/bisq/pull/7378 | <ul dir="auto"> <li><a href="https://github.com/bisq-network/bisq/commit/958661f25bf31624e82af0778fd6974052837682">Show XMR subaddress popup if user has non-subaddress account</a> <ul dir="auto"> <li>Before PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2317672085" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/7123" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/7123/hovercard" href="https://github.com/bisq-network/bisq/pull/7123">#7123</a>, we showed the XMR subaddress popup whenever the user navigated to the account tab. After PR <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2317672085" data-permission-text="Title is private" data-url="https://github.com/bisq-network/bisq/issues/7123" data-hovercard-type="pull_request" data-hovercard-url="/bisq-network/bisq/pull/7123/hovercard" href="https://github.com/bisq-network/bisq/pull/7123">#7123</a>, we show the XMR subaddress popup if the user has an XMR account. However, it's better show the popup if the user has a non-subaddress XMR account.</li> </ul> </li> <li><a href="https://github.com/bisq-network/bisq/commit/5e04336c4d0daa17c3dff1b401eaace0a8433222">Show XMR subaddress popup during account creation</a> <ul dir="auto"> <li>Additionally show the XMR subaddress popup during account creation, so that user can look up how subaddresses work and set it up.</li> </ul> </li> <li><a href="https://github.com/bisq-network/bisq/commit/861f655ae7de9d42196aa6deb696c78b57fa5266">Refactor duplicate XMR subaddress popup code</a></li> </ul> |
| bisq: AltCoinAccountsDataModel: Handle XMR detection NullPointerException | dev | | https://github.com/bisq-network/bisq/pull/7379 | The PaymentAccount.getSingleTradeCurrency(...) method can return null in certain cases. |
| bisq: Implement deflate compressed log zipper | dev | | https://github.com/bisq-network/bisq/pull/7380 | <ul dir="auto"> <li><a href="https://github.com/bisq-network/bisq/commit/d43ecfbe530af29b24c7c9e5ad4a38fcaec2e9e6">Implement log files finder</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/5ca57be231cb53e7b631e8d712f52f8c57530e58">LogFilesFinder: Find log files containing trade id</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/13fdd196ca1104008cd656c41d63076753a72801">Implement LogFilesZipper</a></li> <li><a href="https://github.com/bisq-network/bisq/commit/256ab05bcdbf6df07ab5de6ea5340b463d806dcf">LogFilesZipper: Compress using DEFLATE</a></li> </ul> |
| bisq: Use deflate compressed log zipper in backup view | dev | | https://github.com/bisq-network/bisq/pull/7381 | <ul dir="auto"> <li><a href="https://github.com/bisq-network/bisq/commit/192c5f69c1759b2a42274ac57366bc47cfef67f5">BackupView: Use new LogFileZipper</a></li> </ul> |
| bisq: BackupView: Show error message if log files zipping fail | dev | | https://github.com/bisq-network/bisq/pull/7382 | |
| bisq: FileUtils: Close files after scanning for keywords | dev | | https://github.com/bisq-network/bisq/pull/7384 | |
| | dev | 20000 | | Total for items above.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

For Cycle 67 #1724

Summary

Contributions delivered

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Title	Team	USD	Link	Notes
PR Review (for v1.9.19): Optimise/simplify some stream filtering for the REST API	dev		bisq-network/bisq#7221	utACK - While reviewing this PR I found and fixed unrelated threading issues.
PR Review (for v1.9.19): Remove emzy bsq explorer	dev		bisq-network/bisq#7213	NACK - This PR adds the changes to the wrong place. This mistake wasn't caught in PR 7014. The Preferences class already has a clearRetiredNodes method that handles this use-case. I created follow-up PRs to resolve this issue.
PR Review (for v1.9.19): Rename provider repository	dev		bisq-network/bisq#7214	utACK
PR Review (for v1.9.19): Add bisq.mempool.emzy.de to filter of persisted preferences	dev		bisq-network/bisq#7222	utACK
PR Review (for v1.9.19): Add 2 new BTC nodes	dev		bisq-network/bisq#7231	utACK
PR Review (for v1.9.19): Produce exclusively low-R signatures from wallet keys	dev		bisq-network/bisq#7238	utACK.
PR Review (for v1.9.19): Add missing isBmFullNode parameter	dev		bisq-network/bisq#7239	utACK
PR Review (for v1.9.19): Fix broken low-R signing with a password encrypted wallet	dev		bisq-network/bisq#7242	utACK
PR Review (for v1.9.19): URL was broken with the /bisq path and just redirecting to mempool front page	dev		bisq-network/bisq#7246	ACK
PR Review (for v1.9.19): Add suddenwhipvapor onion xmr explorer	dev		bisq-network/bisq#7245	utACK
PR Review (for v1.9.19): Update seednode burningman oracle keys	dev		bisq-network/bisq#7248	utACK
PR Review (for v1.9.19): Sort foreign alphabet payment methods above the untranslated ones.	dev		bisq-network/bisq#7251	utACK - The regex matches ASCII characters according to the Windows-1252 (CP-1252) spec which is a superset of ISO 8859-1 (ISO-Latin-1) but that is fine in our case.
PR Review (for v1.9.19): Improve exception msg and handling when 'Same Bank' BIC/SWIFT blank	dev		bisq-network/bisq#7258	utACK
PR Review (for v1.9.19): "Transfer Same Bank" & "Transfer Specific Banks" match case-insentitivity	dev		bisq-network/bisq#7257	utACK
PR Review (for v1.9.19): Language strings file cleanup; added missing, applied rename	dev		bisq-network/bisq#7253	utACK
PR Review (for v1.9.19): Create payment method "Faster Payments System (SBP)" for Russian Ruble	dev		bisq-network/bisq#7255	ACK + Nit - SbpForm has a redundant cast to SbpAccountPayload SbpForm has a redundant BankNameField variable declaration. SbpForm defines holder name getters and setters that are identical to superclass. It's hard for the seller to read the buyer's account details because the string is long, e.g, "Account owner name (first, middle, and initial of last name): Alice A., Mobile no. +71234567890, Bank name SBP Bank". I shortened "Account owner name (first, middle, and initial of last
name)" to "Account owner name". I created follow-up PRs that resolve these issues.
PR Review (for v1.9.19): Fix randomly blank currency box upon opening the Offer screen	dev		bisq-network/bisq#7259	utACK
PR Review (for v1.9.19): New option in PhoneNumberValidator to enforce exact number of digits	dev		bisq-network/bisq#7252	Nit - Jamaica (JMM) has two codes. I created a follow-up PR to fix this.
PR Review (for v1.9.19): Create payment method "Faster Payments System (SBP)" for Russian Ruble	dev		bisq-network/bisq#7265	utACK - I used a translator to verify the Persian, Chinese Simplified, and Chinese Traditional translations. It would be good for native speakers to verify the translations.
PR Review (for v1.9.19): Added 500+ string translations to Russian language file	dev		bisq-network/bisq#7268	utACK
PR Review (for v1.9.19): Added 500+ string translations to Russian language file	dev		bisq-network/bisq#7269	utACK
PR Review (for v1.9.19): Add missing swagger doc directory	dev		bisq-network/bisq#7299	utACK
PR Review (for v1.9.19): Update seednode install script to generate ECDSA key for BM oracle node	dev		bisq-network/bisq#7325	utACK
PR Review (for v1.9.19): Add instruction to select JDK version at build time	dev		bisq-network/bisq#7327	utACK
PR Review (for v1.9.19): Fix typo in Argentinian Peso (ARS) message	dev		bisq-network/bisq#7326	utACK
PR Review (for v1.9.19): fix: remove unnecessary null check, use correct marker class, add mis…	dev		bisq-network/bisq#7348	utACK
PR Review (for v1.9.19): Add link to trading rules wiki article in Tac Window	dev		bisq-network/bisq#7349	utACK
PR Review (for v1.9.19): Add suddenwhipvapor mediator instance onion	dev		bisq-network/bisq#7350	utACK
PR Review (for v1.9.19): fix: Utilities.getShortId and FluentProtocol.preCondition usage	dev		bisq-network/bisq#7351	utACK
PR Review (for v1.9.19): Prepare activation to reduce min security deposit	dev		bisq-network/bisq#7357	utACK
PR Review (for v1.9.19): Change MIN_SECURITY_DEPOSIT_CHANGE_ACTIVATION_DATE to 17.2.2025	dev		bisq-network/bisq#7364	utACK
PR Review (for v1.9.19): Reduce maximum trade size for unsigned payment accounts	dev		bisq-network/bisq#7364	utACK - I found some bugs while I was reviewing this PR.
PR Review (for v1.9.19): Ensure AutoConfirmSettings is reset if it contains my retired explorer	dev		bisq-network/bisq#7364	utACK - I found some bugs while I was reviewing this PR.
Fixed, re-wrote, and tested (on all OSes) Bisq 1 installer verification instructions	dev			https://bisq.wiki/Downloading_and_installing#Bisq_1:_Obtain_signature_files_for_installer_files
bisq: PR Review bisq-network/bisq#7364	dev		bisq-network/bisq#7364	utACK
bisq: PR Review bisq-network/bisq#7365	dev		bisq-network/bisq#7365	utACK
bisq: PR Review bisq-network/bisq#7368	dev		bisq-network/bisq#7368	utACK
bisq: PR Review bisq-network/bisq#7373	dev		bisq-network/bisq#7373	DAO hashes match with my full nodes.
bisq: PR Review bisq-network/bisq#7374	dev		bisq-network/bisq#7374	utACK
bisq: PR Review bisq-network/bisq#7375	dev		bisq-network/bisq#7375	utACK
bisq: PR Review bisq-network/bisq#7386	dev		bisq-network/bisq#7386	utACK
bisq: Makefile: Add exec-commands to .PHONY target	dev		bisq-network/bisq#7369	Add bitcoind, seednode, seednode2, mediator, alice, bob, block, and blocks to .PHONY target.
bisq: Sbp trade UI fixes	dev		bisq-network/bisq#7370	SbpForm: Remove redundant cast to SbpAccountPayload SbpForm: Remove unused bank name variable declaration SbpForm: Remove holder name getter and setter (already in super class) AccountAgeWitnessService: Invert toleration condition displayString: Rename payment.account.owner to payment.account.owner.fullname SBP Trade: Make account name description readable It's hard for the seller to read the buyer's account details because the string is long, e.g, "Account owner name (first, middle, and initial of last name): Alice A., Mobile no. +71234567890, Bank name SBP Bank". I shortened "Account owner name (first, middle, and initial of last name)" to "Account owner name".
bisq: Update Alejandro's public key	dev		bisq-network/bisq#7371	Alejandro's GPG key expired and he extended the key's expiration date.
bisq: Fix phone number required lengths	dev		bisq-network/bisq#7372	PhoneNumberRequiredLengths: Jamaica (JMM) has two codes PhoneNumberRequiredLengths: Puerto Rico (PR) has two codes
bisq: XMR: Fix broken subaddress docs link	dev		bisq-network/bisq#7377
bisq: Improve XMR subaddress popup behaviour	dev		bisq-network/bisq#7378	Show XMR subaddress popup if user has non-subaddress account Before PR #7123, we showed the XMR subaddress popup whenever the user navigated to the account tab. After PR #7123, we show the XMR subaddress popup if the user has an XMR account. However, it's better show the popup if the user has a non-subaddress XMR account. Show XMR subaddress popup during account creation Additionally show the XMR subaddress popup during account creation, so that user can look up how subaddresses work and set it up. Refactor duplicate XMR subaddress popup code
bisq: AltCoinAccountsDataModel: Handle XMR detection NullPointerException	dev		bisq-network/bisq#7379	The PaymentAccount.getSingleTradeCurrency(...) method can return null in certain cases.
bisq: Implement deflate compressed log zipper	dev		bisq-network/bisq#7380	Implement log files finder LogFilesFinder: Find log files containing trade id Implement LogFilesZipper LogFilesZipper: Compress using DEFLATE
bisq: Use deflate compressed log zipper in backup view	dev		bisq-network/bisq#7381	BackupView: Use new LogFileZipper
bisq: BackupView: Show error message if log files zipping fail	dev		bisq-network/bisq#7382
bisq: FileUtils: Close files after scanning for keywords	dev		bisq-network/bisq#7384
	dev	20000		Total for items above.

For Cycle 67 #1724

Description

Summary

Contributions delivered

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions