fix: remove unnecessary null check, use correct marker class, add mis… #7348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! |
…sing return keyword
HenrikJannsen
requested changes
Jan 4, 2025
| protected void run() { | ||
| if (model.getWalletService().isUnconfirmedTransactionsLimitHit() || model.getBsqWalletService().isUnconfirmedTransactionsLimitHit()) | ||
| failed(Res.get("shared.unconfirmedTransactionsLimitReached")); | ||
| return failed(Res.get("shared.unconfirmedTransactionsLimitReached")); |
There was a problem hiding this comment.
The curly brackets at the if are missing. The failed() method has void as return type so it cannot be used as return statement.
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sing return keyword, and fix Preferences.setRpcUser
as discussed and confirmed on matrix chat (bisq v1 dev channel), these are minor bugs, so I made a PR
resolves #7347