Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Conversation

@djsmith85
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Re-created changes from #1380 due to too many merge issues and introduction of eslint

With 1Password changing their export format from .1pif to .1pux in recent versions, this adds an importer to import 1pux into Bitwarden.

The 1pux format is essentially a zip archive including multiple files. The initial one of interest is the export.data file which contains the vault data.

Further information about the new 1pux format can be found here: https://support.1password.com/1pux-format/

Depends on bitwarden/jslib#594

Asana task: https://app.asana.com/0/1153292148278596/1201437354678085/f

Code changes

  • jslib: Pull in changes made in Add importer for 1Password's new export format (.1pux) jslib#594
  • package.json: Installed jszip
  • package-lock.json: Changes after executing npm i
  • src/app/tools/import.component.html: Display additional instructions and link to help site when selecting 1pux importer
  • src/app/tools/import.component.ts: Unzip .1pux file and pass content of export.data to 1pux importer

Testing requirements

Testing should include importing several .1pux exports and should handle all mappings detailed in bitwarden/jslib#594

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@djsmith85 djsmith85 requested a review from a team March 2, 2022 13:44
differsthecat
differsthecat previously approved these changes Mar 3, 2022
Copy link
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@djsmith85 djsmith85 requested a review from differsthecat March 3, 2022 14:38
@djsmith85 djsmith85 merged commit 1076749 into master Mar 3, 2022
@djsmith85 djsmith85 deleted the 1pux-importer2 branch March 3, 2022 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants