Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Conversation

@cscharf
Copy link
Contributor

@cscharf cscharf commented Feb 25, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Remove Artifact binding capabilities from Bitwarden's SSO service for now; they may be added back in the future.
see: https://app.asana.com/0/1169444489336079/1201340159635915/f
see: CSA-6

Code changes

  • sso.component.html:
  • sso.component.ts:

Screenshots

image

Testing requirements

  • Ensure you can still configure SAML SSO via the web vault and the configuration saves and loads as expected
  • Ensure you can still configure OpenID Connect SSO via the web vault and the configuration saves and loads as expected
  • See: CSA-6 Fix/remove artifact binding server#1885

Documentation updates

cc: @fschillingeriv
Because this removes the underlying functionality for the Artifact binding and associated Artifact Endpoint URL configuration in the UI when configuring SAML, this update will need to be made to the documentation when this goes live (likely in March release). See: bitwarden/server#1885.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@cscharf cscharf requested a review from a team February 25, 2022 22:29
@cscharf cscharf merged commit f832cb4 into master Feb 28, 2022
@cscharf cscharf deleted the remove-artifact-binding branch February 28, 2022 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants