Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Mar 22, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Updates to use the new constants from bitwarden/jslib#723

EC-109

Testing requirements

Regression test actions related to KDF.

  • Register
  • Login
  • Change KDF
  • Create, modify, access send with password

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@Hinton Hinton marked this pull request as ready for review March 24, 2022 09:52
@Hinton Hinton requested a review from a team March 24, 2022 09:52
Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the cleanup for IE and getting rid of magic numbers

@Hinton Hinton merged commit 00975e6 into master Mar 24, 2022
@Hinton Hinton deleted the feature/kdf branch March 24, 2022 10:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants