Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Conversation

@Hinton
Copy link
Member

@Hinton Hinton commented Mar 24, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Bump node-forge bitwarden/jslib#722

EC-111

Testing requirements

Our normal regression testing should cover this. (Node-forge is used in all jslib clients for cryptographic operations).

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@Hinton Hinton requested a review from a team March 24, 2022 09:43
djsmith85
djsmith85 previously approved these changes Mar 24, 2022
@Hinton Hinton requested a review from djsmith85 March 24, 2022 10:44
@Hinton Hinton enabled auto-merge (squash) March 24, 2022 10:44
@Hinton Hinton merged commit 0884e2d into master Mar 24, 2022
@Hinton Hinton deleted the feature/node-forge branch March 24, 2022 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants