This repository was archived by the owner on Mar 15, 2024. It is now read-only.
generator updates #1575
Merged
generator updates #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliykat
previously approved these changes
Apr 1, 2022
This reverts commit b2b13ac.
eliykat
approved these changes
Apr 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Apply client updates from bitwarden/jslib#753
Code changes
React to changes from bitwarden/jslib#753
Also, added a "learn more" icon for username types on the generator.
NOTE: I still need to update jslib once bitwarden/jslib#753 is merged.
Before you submit
npm run lint) (required)