Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Jun 3, 2024

🎟️ Tracking

Internal change.

📔 Objective

Configures coverage exclusions.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Logo
Checkmarx One – Scan Summary & Details9cca262a-abcd-4b09-b0e9-718b537e1396

No New Or Fixed Issues Found

@withinfocus withinfocus marked this pull request as ready for review June 3, 2024 19:26
@withinfocus withinfocus requested a review from a team as a code owner June 3, 2024 19:26
@withinfocus withinfocus requested a review from a team June 5, 2024 19:33
Copy link
Contributor

@SaintPatrck SaintPatrck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@withinfocus withinfocus merged commit dc0413b into main Jun 5, 2024
@withinfocus withinfocus deleted the cov branch June 5, 2024 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants