Skip to content
This repository was archived by the owner on May 25, 2022. It is now read-only.

Conversation

@djsmith85
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With 1Password changing their export format from .1pif to .1pux in recent versions, this adds an importer to import 1pux into Bitwarden.

The 1pux format is essentially a zip archive including multiple files. The initial one of interest is the export.data file which contains the vault data.

Further information about the new 1pux format can be found here: https://support.1password.com/1pux-format/

Depends on bitwarden/jslib#594

Asana task: https://app.asana.com/0/1153292148278596/1201437354678085/f

Code changes

  • jslib: Pull in changes made in Add importer for 1Password's new export format (.1pux) jslib#594
  • package.json: Installed jszip
  • package-lock.json: Changes after executing npm i
  • src/commands/import.command.ts: Add condition to call utils-method
  • src/utils.ts: Add method to unzip a .1pux file and pass content of export.data back to import.command

Testing requirements

Testing should include importing several .1pux exports and should handle all mappings detailed in bitwarden/jslib#594

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@djsmith85 djsmith85 changed the title 1pux importer Add importing of 1passwords 1pux files Jan 8, 2022
@djsmith85 djsmith85 requested a review from a team March 2, 2022 14:13
@djsmith85 djsmith85 marked this pull request as ready for review March 2, 2022 14:13
Copy link
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@djsmith85 djsmith85 merged commit caf6a11 into master Mar 3, 2022
@djsmith85 djsmith85 deleted the 1pux-importer branch March 3, 2022 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants