This repository was archived by the owner on Jul 23, 2022. It is now read-only.
[PS-74] Fix user authentication state checks #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
eliykat
commented
Mar 29, 2022
| class="bwi bwi-lock bwi-2x text-muted" | ||
| class="bwi bwi-2x text-muted" | ||
| [ngClass]=" | ||
| a.value.profile.authenticationStatus == authStatus.Unlocked ? 'bwi-unlock' : 'bwi-lock' |
There was a problem hiding this comment.
No real change here, I just find ngClass to be more succinct when swapping between icons.
| <button | ||
| *ngFor="let a of accounts | keyvalue" | ||
| class="account" | ||
| [ngClass]="{ active: a.value.profile.authenticationStatus == 'active' }" |
There was a problem hiding this comment.
This class will never be applied because the active account is excluded from the switcherAccount list. Also doesn't appear to have any scss styling associated with it.
Once we remove this, we don't need the authenticationStatus.active value at all.
There was a problem hiding this comment.
Yea, this was a design change and this never got removed.
Hinton
approved these changes
Apr 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Consequential changes from bitwarden/jslib#721. Depends on that being merged.
Code changes
authService.authStatus()methodaccount.profile.activeproperty which was unusedAuthenticationStatusenum being number instead of string valuesScreenshots
Testing requirements
Before you submit
npm run lint) (required)