This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Component Library scaffolding #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…ure/component-library
…ure/component-library
Hinton
commented
Feb 17, 2022
…ure/component-library # Conflicts: # .prettierignore # package.json
danielleflinn
previously approved these changes
Mar 1, 2022
vincentsalucci
previously approved these changes
Mar 5, 2022
vincentsalucci
approved these changes
Mar 7, 2022
This was referenced Mar 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Adds the scaffolding for the Component Library. It's packaged as an Angular cli application to provide support for storybook. In the long term we should look into how we can run storybook outside jslib since it's currently limited to components within jslib, which is a bit limited.
Tailwind is configured to use the prefix
tw-to avoid clashing with bootstrap.This project is setup slightly different to most of our projects in that it has
index.tswhich exposes a public api. This is intentional as a way to define a public api.Resolves:
Before you submit
npm run lint) (required)