Skip to content
This repository was archived by the owner on Jun 17, 2022. It is now read-only.

Conversation

@addisonbeck
Copy link
Contributor

@addisonbeck addisonbeck commented Mar 3, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

We aren't completely removing keytar keys right now, and instead are just nulling out values. We should be completely cleaning up those keys if they are set to null, like on logout..

Code changes

To achieve this I checked for a null value on any secure storage set operations and used the remove method instead of save if the passed in value is null.

Screenshots

Screen.Recording.2022-03-03.at.12.03.29.PM.mov

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@addisonbeck addisonbeck requested a review from a team March 3, 2022 17:07
@addisonbeck addisonbeck force-pushed the Bug/DeleteStoredKeys branch from 3cad640 to 35cef72 Compare March 3, 2022 17:08
@addisonbeck addisonbeck enabled auto-merge (squash) March 3, 2022 17:10
@addisonbeck addisonbeck merged commit 4d94f7a into master Mar 3, 2022
@addisonbeck addisonbeck deleted the Bug/DeleteStoredKeys branch March 3, 2022 18:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants