Skip to content
This repository was archived by the owner on Jun 17, 2022. It is now read-only.

Conversation

@djsmith85
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With #708 we added the new Dashlane csv importer. As Dashlane has removed support for the JSON format, the CSV importer should be on the featureList instead

Code changes

  • common/src/enums/importOptions.ts: Removed the Dashlane json importer from the featured importer list

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@djsmith85 djsmith85 requested a review from a team March 7, 2022 18:47
@djsmith85 djsmith85 enabled auto-merge (squash) March 7, 2022 19:07
@djsmith85 djsmith85 merged commit 18b9546 into master Mar 7, 2022
@djsmith85 djsmith85 deleted the remove-dashlane-json-from-featured-list branch March 7, 2022 22:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants