Type of change

• Bug fix
• New feature development
• Tech debt (refactoring, code cleanup, dependency upgrades, etc)
• Build/deploy pipeline (DevOps)
• Other

Objective

It seems that 1password has changed the structure of their 1pux file format, since I wrote the importer with the file I received.

//Before:
items: [
  {
     item: {
     }
  }
]

//Current
items: [
  {
  }
]

This will need to be 🍒 ⛏️ to rc

Asana task: https://app.asana.com/0/1200578627114106/1201633451894388/f

Code changes

• common/src/importers/onepasswordImporters/types/onepassword1PuxImporterTypes.ts:
  • Removed the ItemCollection type and use Item[] instead
  • Made item.trashed and optional property
• common/src/importers/onepasswordImporters/onepassword1PuxImporter.ts:
  • Removed the import of the no longer needed ItemCollection
  • Fixed the type used in the vaults.items.forEach
• spec/common/importers/testData/onePassword1Pux/*.ts: Removed the unneeded named object item from the items[]

Before you submit

• I have checked for linting errors (npm run lint) (required)
• I have added unit tests where it makes sense to do so (encouraged but not required)
• This change requires a documentation update (notify the documentation team)
• This change has particular deployment requirements (notify the DevOps team)