Skip to content

Conversation

@dani-garcia
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes #50. Also added support for NO_COLOR, which clap already respects, but we didn't.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)

Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@dani-garcia dani-garcia merged commit 796a1be into master Jun 5, 2023
@dani-garcia dani-garcia deleted the fix-color-errors branch June 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--color no not respected for errors

3 participants